search

Yoast / PHPUnit-Polyfills

Set of polyfills for changed PHPUnit functionality to allow for creating PHPUnit cross-version compatible tests
BSD 3-Clause "New" or "Revised" License
173 stars 13 forks source link

Tests: improve PHP 8.4 deprecation work-around #170

Closed jrfnl closed 4 months ago

jrfnl commented 4 months ago

Follow-up on PR #159.

This commit builds on the earlier change, but instead of making the whole AssertObjectEqualsTest class have a PHP 7.1 minimum requirement, it now limits that requirement to just the one affected test.

The affected test now uses a separate test fixture to allow the bulk of the tests to run on PHP 7.0 (which was the previous minimum requirement for these tests).

coveralls commented 4 months ago

Coverage Status

coverage: 95.833% (+0.2%) from 95.679% when pulling 5c585709a49ad5b4f1de1f32b0383d4c6e10491d on feature/improve-php-8.4-workaround-implicitly-nullable into 8c2f83340539c1345794777b96c18abde9474fce on 2.x.

jrfnl commented 4 months ago

Superseded by #171 (this was pulled to the wrong branch 🤦🏻‍♀️ )