Yoast / PHPUnit-Polyfills

Set of polyfills for changed PHPUnit functionality to allow for creating PHPUnit cross-version compatible tests
BSD 3-Clause "New" or "Revised" License
173 stars 13 forks source link

GH Actions: use "nightly" instead of version nr for PHP-dev #180

Closed jrfnl closed 2 months ago

jrfnl commented 2 months ago

The setup-php action runner offers the nightly alias for the PHP "dev" version. By using that alias instead of the hard-coded version number for PHP "next", the manual maintenance needed for the workflows is decreased and made less error-prone.

This also fixes the current "error" that the conditions for the "composer install" step still referenced PHP 8.3 instead of PHP 8.4.

There is a small down-side to this change. To explain this, we need to understand the PHP release cycle.

What this means for the workflows is as follows:

So the practical implications are that the "updating the workflow for the newly released PHP version" task, which is normally executed round the time of the release of a new PHP version, should be moved forward to the time when the first RC of the new PHP version is cut.

As this is a tool used in CI of other projects, officially supporting a new PHP version early, makes sense though, so this "early" update of the workflows for a new PHP version also makes sense.

coveralls commented 2 months ago

Coverage Status

coverage: 96.408%. remained the same when pulling 3496c576e37bc0b561e0dc4ac176d511a4c6e61f on feature/1.x-ghactions-use-nightly-for-php-next into f3a7fbdb42918f2edc170f51be6cf5dda40032ed on 1.x.