search

Yoast / Yoast-SEO-for-Magento2

Yoast SEO for Magento 2
Other
70 stars 28 forks source link

Strict Mode #66

Closed Joostdijck closed 6 years ago

Joostdijck commented 6 years ago

The plugin will not work in strict mode because "with(obj) {}"statement is being used in "yoast-seo.min.js" in these places: templates['assessmentPresenterResult'] line 13310 templates['hiddenSpan'] line 13378 templates['relevantWords'] line 13396 templates['snippetEditor'] line 13427

So either turn strict mode off for these functions, or rewrite the code so with (obj) statements are not used.

vincenthornikx commented 6 years ago

Hi @Joostdijck, I've notified the Yoast team about this. I'm afraid I can't fix this myself as the issue is in their codebase.

vincenthornikx commented 6 years ago

@Joostdijck according to the Yoast team this issue should be resolved now at their end. I have imported their latest libraries in the 2.0.0 release.