[BUGFIX] Show favicon without base url in link tag correctly in snippet preview - Githubissues

Yoast / Yoast-SEO-for-TYPO3

Yoast SEO plugin for TYPO3

Other

51 stars 56 forks source link

[BUGFIX] Show favicon without base url in link tag correctly in snippet preview #480

Closed brotkrueml closed 1 year ago

brotkrueml commented 2 years ago

This fixes the error on PHP 8.1:

Trying to access array offset on value of type bool in /var/www/html/public/typo3conf/ext/yoast_seo/Classes/Service/PreviewService.php line 149

Additionally, the favicon is now also displayed correctly when the URL has a port.

Summary

This PR can be summarized in the following changelog entry:

Show favicon without base url in link tag correctly in snippet preview

Test instructions

This PR can be tested by following these steps:

The shortcut icon should be defined as <link rel="shortcut icon" href="/favicon.ico">
Under PHP 8.1 the given error is displayed.
Additionally, configure your test system with a port (like 8080).
Previously, the favicon was not displayed in snippet preview, now it is shown.

Quality assurance

[x] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended