Fix keyphrase in slug researcher for compound keyphrases with hyphens - Githubissues

Yoast / YoastSEO.js

Analyze content on a page and give SEO feedback as well as render a snippet preview.

GNU General Public License v3.0

403 stars 170 forks source link

Fix keyphrase in slug researcher for compound keyphrases with hyphens #2129

Closed nataliashitova closed 5 years ago

nataliashitova commented 5 years ago

Summary

This PR can be summarized in the following changelog entry:

Fixes the bug when a compound keyphrase with a hyphen would not be recognized in the slug.

Relevant technical choices:

The currently implemented algorithm splits a compound word in two and thus counts it as two separate words. So the keyphrase awesomest video-games would be treated as three separate words in the keyphraseInSlug assessment (awesomest, video and games) and matching just video-games in a slug would be enough to score a green bullet.

Test instructions

This PR can be tested by following these steps:

Check if keyphrases with hyphens are correctly recognized in the slug
Try combining words with and without hyphens in the keyphrase and see if they are correctly recognized in the slug
Check if keyphrases without hyphens are correctly recognized in the slug

Fixes #2121

bintzandt commented 5 years ago

PR has been replaced by https://github.com/Yoast/javascript/pull/19.