Implement TreeAssessor - Githubissues

Yoast / YoastSEO.js

Analyze content on a page and give SEO feedback as well as render a snippet preview.

GNU General Public License v3.0

403 stars 171 forks source link

Implement TreeAssessor #2142

Closed hansjovis closed 5 years ago

hansjovis commented 5 years ago

Summary

This PR can be summarized in the following changelog entry:

[not-user-facing] Adds the TreeAssessor, which is going to be used for assessments in the (near) future.

Relevant technical choices:

Adds a test assessment and test aggregator (in specs/specHelpers) to help with testing the TreeAssessor functionality.
Fixes the JSDoc module structure for tree/research to include the TreeResearcher and Research classes.

Test instructions

This PR can be tested by following these steps:

Run the tests using yarn test. Check that the coverage of all files in the src/tree/assess folder is 100% (instead of index.js).
Review the code. Check if you do not see any (edge) cases not covered by the implementation of the TreeAssessor and related functionality.

Fixes #2123

manuelaugustin commented 5 years ago

CR of the latest commits & acceptance 👍

manuelaugustin commented 4 years ago

Fixes https://github.com/Yoast/javascript/issues/413