Feature/german morphology - Githubissues

Yoast / YoastSEO.js

Analyze content on a page and give SEO feedback as well as render a snippet preview.

GNU General Public License v3.0

403 stars 171 forks source link

Feature/german morphology #2171

Closed manuelaugustin closed 5 years ago

manuelaugustin commented 5 years ago

Summary

This PR can be summarized in the following changelog entry:

Adds word form recognition for German.

Relevant technical choices:

see the individual PRs for German nouns/adjectives/verbs:
- Stemmer/nouns: https://github.com/Yoast/YoastSEO.js/pull/2054
- Adjectives: https://github.com/Yoast/YoastSEO.js/pull/2133
- Verbs: https://github.com/Yoast/YoastSEO.js/pull/2153
For code review, just have a look at the latest commit. The others have already been reviewed in the individual PRs (see above).

Test instructions

This PR can be tested by following these steps:

All functionality for morphology has been tested in the individual PRs; for this PR, a quick global check should be sufficient.
Add a keyphrase with a noun, adjective and verb.
Add different forms of the words in the text. For this, you can use a dictionary entry with forms, such as e.g. https://de.wiktionary.org/wiki/Flexion:kaufen.
Make sure the different forms get recognized.

Fixes #2159

hansjovis commented 5 years ago

Acceptance test: ✅ .

A quick test with some German word forms revealed that they are all recognized 😄. Good job!