Create readability score aggregator - Githubissues

Yoast / YoastSEO.js

Analyze content on a page and give SEO feedback as well as render a snippet preview.

GNU General Public License v3.0

403 stars 171 forks source link

Create readability score aggregator #2176

Closed hansjovis closed 5 years ago

hansjovis commented 5 years ago

Summary

This PR can be summarized in the following changelog entry:

[non-user-facing] Adds a ReadabilityScoreAggregator that should serve as a replacement for the score aggregation part of the current contentAssessor in the (near) future.

Relevant technical choices:

Uses the same logic as in contentAssessor.
May get some merge conflicts when #2173 is merged first, since it restructures the folder structure somewhat. These changes may not coincide with the structure in this branch.

Test instructions

This PR can be tested by following these steps:

Look at the code.
- Specifically, check if the logic used is the same as the score aggregation functionality in contentAssessor (The aggregate method in the ReadabilityScoreAggregator method should implement the same logic as the calculateOverallScore method).
- Run the tests.
- Check that the coverage is 100% for the ReadabilityScoreAggregator.
- Check that all tests pass.

Fixes #2125

igorschoester commented 5 years ago

CR & Acceptance 👍