search

Yoast / YoastSEO.js

Analyze content on a page and give SEO feedback as well as render a snippet preview.
GNU General Public License v3.0
403 stars 170 forks source link

Wrong Number of Links Detected In Italian #949

Open amboutwe opened 7 years ago

amboutwe commented 7 years ago

What did you expect to happen?

Correctly identify the number of nofollow vs normal outbound links.

What happened instead?

If all links are nofollow, the correct message appears. If there is a mix of nofollow and normal or if they are all normal links, the warning always shows one nofollow outbound link.

How can we reproduce this behavior?

Change WP language to Italian (it-IT). Create a new post. Add one normal link. Look at the analysis. See Green bullet mislabel nofollow link. "Questa pagina ha in uscita 1 link nofollow e link normali."

Can you provide a link to a page which shows this issue?

Technical info

Additional Information

:-1: All normal links = Questa pagina ha in uscita 1 link nofollow e link normali. :-1: Mix of both links = Questa pagina ha in uscita 1 link nofollow e link normali. :+1: All nofollow links = Questa pagina ha link in uscita, tutti nofollow.

Workaround

Switch language to English to get the correct detection.

terw-dan commented 7 years ago

It seems the translations of these messages are incorrect. The tests are correct, only the output message makes no sense.

afercia commented 7 years ago

Tested and confirmed it's because of wrong placeholder numbers in the translated strings. Will be fixed with the new translations.

terw-dan commented 7 years ago

The strings in this assessment could be improved. Currently we don't have a separation between single and plurals. We simply use link(s). However, in Italian the word normal also has a plural and a single version normali & normale We could improve the strings to support singles and plurals.

amboutwe commented 7 years ago

Please inform the customer of conversation # 159376 when this conversation has been closed.