Yoast / YoastSEO.js

Analyze content on a page and give SEO feedback as well as render a snippet preview.
GNU General Public License v3.0
403 stars 170 forks source link

Improve the matching with different apostrophe's. #997

Open terw-dan opened 7 years ago

terw-dan commented 7 years ago

In French, another apostrophe is used than in English.

We should improve the matching so these are all matched.

example -> the storm (English) = l’orage (French / le + orage, we must replace the vowel of the article by this apostrophe), which would therefore cause the keyword "orage" to not be recognized

This replaces: https://github.com/Yoast/wordpress-seo/issues/6076

How can we reproduce this behavior?

Use a &rsquo instead of ' and see the words don't match.

Technical info

terw-dan commented 7 years ago

@IreneStr Can you check if there are other characters that we should also match? So we can fix the matching of all characters all at once?

IreneStr commented 7 years ago

The following apostrophes are used before/after suffixes, to replace vowels etc.:

We should not enable this for all languages, because these characters can also be used as a character within words. In Hawaiian, for example ' is used to indicate a glottal stop. We wouldn't want to detect the focus keyword 'oli' (they) in a word like hauʻoli (joy).

We should differentiate between apostrophes used before keywords (l'orage, French), and apostrophes used after keywords (John's, English).

Before keywords:

After keywords:

Pcosta88 commented 7 years ago

Please inform the customer of conversation # 200749 when this conversation has been closed.

Pcosta88 commented 7 years ago

related: https://github.com/Yoast/wordpress-seo/issues/6180

Pcosta88 commented 7 years ago

Please inform the customer of conversation # 197281 when this conversation has been closed.

Pcosta88 commented 7 years ago

Please inform the customer of conversation # 201398 when this conversation has been closed.

Pcosta88 commented 7 years ago

user says,

I think the best thing to do would be to identify keywords inside text, titles and descriptions WITHOUT taking apostrophes into consideration. In other words, the Yoast SEO plugin ignores apostrophes and just concentrates on the words themselves.