Technical choices that affect more than this issue:
Test instructions
This PR can be acceptance tested by following these steps:
Homepage (overview)
Confirm that Twitter tags have become X tags:
Metadata API
Confirm that Twitter presenters have become X presenters:
Rest API
Confirm that in the example output, we have x.com in the sameAs attributes:
Surfaces API
Confirm that all Twitter references in variable descriptions have become X references:
Deprecated filters and actions
Confirm that Twitter image is called now X image:
Integrating Yoast SEO
Confirm that Twitter tags have become X tags:
Controls - Overview
Confirm that all Twitter references in the options descriptions have become X references:
Schema - Specification
Confirm that the Twitter reference in the Other consumers section has become an X reference:
also confirm that in the three examples, of the Company Homepage, the article, with an author, on a company website and the product in a WooCommerce store, we show x.com in the sameAs attributes.
Schema - plugins - Yoast SEO for Shopify
Confirm that in the examples, of the core logic, we show x.com in the sameAs attribute.
X feature
Confirm that the Twitter reference in the sidebar, under Yoast SEO features has become an X reference:
Also confirm that the title has become now Yoast SEO X Tags: Functional specification
And following are all the Twitter references that have become X references (highlighted by the browser search, to help identification):
Note, the A user-defined "X description" value for the page. and A user-defined “Facebook image” in the Social tab of the Yoast metabox in an og:image tag changes and be critical of them.
Quality assurance
[ ] Security - I have thought about any security implications this code might add.
[ ] Performance - I have checked that this code doesn't impact performance (greatly).
[ ] Caching - I have analyzed the caching methods that this code touches and have added instructions to deal with those.
[ ] Tested - I have tested this code to the best of my abilities.
[ ] Automated tests - I have added unit tests to verify the code works as intended.
[ ] Testability - I have added unique ids to elements, so they can be located in automated testing.
[ ] I have altered a filename.
[ ] I have adjusted the ID property accordingly and updated all internal links.
[ ] I have added the redirect to the _redirects file in the root of the project.
Fixes https://github.com/Yoast/reserved-tasks/issues/207
Summary
Relevant technical choices
Technical choices that affect more than this issue:
Test instructions
This PR can be acceptance tested by following these steps:
Homepage (overview)
Confirm that
Twitter tags
have becomeX tags
:Metadata API
Confirm that
Twitter presenters
have becomeX presenters
:Rest API
Confirm that in the example output, we have
x.com
in the sameAs attributes:Surfaces API
Confirm that all
Twitter
references in variable descriptions have becomeX
references:Deprecated filters and actions
Confirm that
Twitter image
is called nowX image
:Integrating Yoast SEO
Confirm that
Twitter tags
have becomeX tags
:Controls - Overview
Confirm that all
Twitter
references in the options descriptions have becomeX
references:Schema - Specification
Twitter
reference in the Other consumers section has become anX
reference:also confirm that in the three examples, of the Company Homepage, the article, with an author, on a company website and the product in a WooCommerce store, we show
x.com
in the sameAs attributes.Schema - plugins - Yoast SEO for Shopify
x.com
in the sameAs attribute.X feature
Twitter
reference in the sidebar, under Yoast SEO features has become anX
reference:Yoast SEO X Tags: Functional specification
Twitter
references that have becomeX
references (highlighted by the browser search, to help identification):Note, the
A user-defined "X description" value for the page.
andA user-defined “Facebook image” in the Social tab of the Yoast metabox in an og:image tag
changes and be critical of them.Quality assurance
_redirects
file in the root of the project.