This PR can be summarized in the following changelog entry:
Fixes a bug where some strings where not translated.
Relevant technical choices:
*
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Generate a .pot file and check all (new) translated strings are there.
List of strings and where to find them:
a Settings link under the plugin's name in the Plugins list
The following labels in the Options page: Title, Date, Status, Slug, Excerpt, Content, Featured Image, Template, Post format, Author, Password, Children, Comments, Menu order, Bulk Actions
when reviewing the changes between a R&R copy and the original: Title, Content, Excerpt, Removed, Added
as aria-label for the links to the original posts: Edit “%s”, Preview “%s”, View “%s”
Test instructions for QA when the code is in the RC
[ ] QA should use the same steps as above.
QA can test this PR by following these steps:
On RC creation, the code is uploaded to SVN trunk on the WP.org plugin repository
You could visit any language (under the Development column) and see if you find the above mentioned strings. If they are there, it already means that the PR works
but if you want to test the user experience, we'll provide translations in some languages (Italian, Dutch)
Then set your WP language to the desired language and check the updates to make sure you get translations for all the plugins and themes (including Duplicate Post)
Check whether all strings have been translated correctly.
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
*
UI changes
[ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.
Documentation
[ ] I have written documentation for this change.
Quality assurance
[x] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended
enricobattocchi
commented
3 years ago
Context
*
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
*
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
.potfile and check all (new) translated strings are there.List of strings and where to find them:
Settingslink under the plugin's name in thePluginslistOptionspage:Title,Date,Status,Slug,Excerpt,Content,Featured Image,Template,Post format,Author,Password,Children,Comments,Menu order,Bulk ActionsTitle,Content,Excerpt,Removed,Addedaria-labelfor the links to the original posts:Edit “%s”,Preview “%s”,View “%s”Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Developmentcolumn) and see if you find the above mentioned strings. If they are there, it already means that the PR worksImpact check
This PR affects the following parts of the plugin, which may require extra testing:
*
UI changes
Documentation
Quality assurance
Fixes DUPP-36 #193