This PR can be summarized in the following changelog entry:
Converts the upgrade notice into a welcome notice for first-time users.
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Either install and activate Yoast Duplicate Post, or if you've already installed it, set the duplicate_post_show_notice option in the _options table to 1.
Activate Yoast Duplicate Post.
You should see a notice that matches the screenshot (see summary above).
Dismiss the notice.
Make sure it does not reappear when refreshing the page.
Deactivate and activate Yoast Duplicate Post, the notice should NOT reappear.
Upgrade the plugin: either change the duplicate_post_version option in _options to a previous version, or checkout a 4.1.* tag from master.
Refresh the plugins page, the notice should NOT reappear.
Test instructions for QA when the code is in the RC
[ ] QA should use the same steps as above.
QA can test this PR by following these steps:
Use a fresh install.
Install and activate Yoast Duplicate Post.
You should see a notice that matches the screenshot (see summary above).
Dismiss the notice.
Make sure it does not reappear when refreshing the page.
Deactivate and activate Yoast Duplicate Post, the notice should NOT reappear.
Upgrade
Install an old version on a clean environment and make sure you get the (old) What's new notice.
Dismiss the notice.
Upgrade to the latest version.
The You've successfully installed notice should NOT appear.
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
*
UI changes
[ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.
Documentation
[ ] I have written documentation for this change.
Quality assurance
[x] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended
maartenleenders
commented
2 years ago
Context
We want the upgrade notice in Duplicate Post to become a "welcome" notice for first time users.
Implementation approved by UX (Corey), see slack.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
duplicate_post_show_noticeoption in the_optionstable to1.duplicate_post_versionoption in_optionsto a previous version, or checkout a4.1.*tag frommaster.Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Upgrade
What's newnotice.You've successfully installednotice should NOT appear.Impact check
This PR affects the following parts of the plugin, which may require extra testing:
*
UI changes
Documentation
Quality assurance
Fixes DUPP-177