Closed jrfnl closed 9 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/ui/newsletter.php | 0 | 1 | 0.0% | ||
<!-- | Total: | 1 | 2 | 50.0% | --> |
Totals | |
---|---|
Change from base Build 6985565176: | 0.04% |
Covered Lines: | 1236 |
Relevant Lines: | 2462 |
Context
*
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Column::register_hooks(): bug fix
The
Column::quick_edit_remove_original()
method only expects one parameter, so no need to ask WP for 2.Newsletter::newsletter_signup_form(): bug fix
The
wp_nonce_field()
function by default displays the field.This means that, as things were, the nonce field would be echo'd out when the function was called + would add a
1
to the$html
string being created. The resulting$html
string would not contain the nonce field and the nonce field would not be between the<form>
tags.Fixed by setting the
$display
parameter tofalse
.Ref: https://developer.wordpress.org/reference/functions/wp_nonce_field/
QA: remove redundant code
The
explode()
function will always return an array, so strict comparing the return value with an empty string will never result in a passing condition.Ref: https://www.php.net/manual/en/function.explode.php
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Display
tab, sectionShow original item
, enableIn a column in the Post list
and saveDelete reference to original item. The original item this was copied from is: <title of the original post>
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
*
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
*
UI changes
Documentation
Quality assurance
Innovation
innovation
label and noted the work hours.Fixes #