"Do not copy these fields" is not working properly, so I will fix it.
Summary
This PR can be summarized in the following changelog entry:
Fixes a bug where using regular expressions in "Do not copy these fields" would not work as expected. Props to @ikuno9233.
Relevant technical choices:
*
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Create a post with custom fields "test_field_1" and "test_field_2" (original post)
Make sure that the "Do not copy these fields" setting ensures that the posts cloned from the original post have custom fields as shown in the table below.
No.
Settings
test_field_1
test_field_2
1
test_field_1,other*
Does not exist
Exists
2
test_field_2,other*
Exists
Does not exist
3
testfield,other*
Exists
Exists
4
testfield*,other*
Does not exist
Does not exist
Relevant test scenarios
[ ] Changes should be tested with the browser console open
[ ] Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
[ ] Changes should be tested on different editors (Block/Classic/Elementor/other)
[ ] Changes should be tested on different browsers
[ ] Changes should be tested on multisite
Test instructions for QA when the code is in the RC
[ ] QA should use the same steps as above.
QA can test this PR by following these steps:
*
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
*
UI changes
[ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.
Documentation
[ ] I have written documentation for this change.
Quality assurance
[x] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended
Innovation
[ ] No innovation project is applicable for this PR.
[ ] This PR falls under an innovation project. I have attached the innovation label and noted the work hours.
ikuno9233
commented
10 months ago
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
*
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
*
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
*
UI changes
Documentation
Quality assurance
Innovation
innovationlabel and noted the work hours.Fixes #