This PR can be summarized in the following changelog entry:
CI/QA update introducing YoastCS 3.0
Relevant technical choices:
Composer/PHPCS: update to YoastCS 3.0.0
YoastCS 3.0.0 has been released and is based on WordPressCS 3.0.0.
This commit makes the necessary updates for that:
Composer: update the requirements.
PHPCS ruleset:
Update a few sniff/property names for new names in WordPressCS 3.0.
Enforce strict PSR-4 for the tests.
Add configuration for the new WordPress.WP.Capabilities sniff.
Remove a few exclusions which are no longer needed.
Add a few selective exclusions for specific situations.
GHA CS workflow: run the CS check on the latest PHP version.
No need to run on PHP 7.4 any more as the deprecations previously encountered were all fixed.
As there are some YoastCS 3.0 issues which still need to be solved by the teams, this changes the CS workflow to use the threshold report instead of expecting a 100% clean code base.
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
If the build runs correctly and passes, we're good.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Composer/PHPCS: update to YoastCS 3.0.0
YoastCS 3.0.0 has been released and is based on WordPressCS 3.0.0.
This commit makes the necessary updates for that:
WordPress.WP.Capabilities
sniff.Refs:
GH Action/cs: use the threshold/branch report
... instead of a full scan.
As there are some YoastCS 3.0 issues which still need to be solved by the teams, this changes the CS workflow to use the threshold report instead of expecting a 100% clean code base.
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps: