Yoast / duplicate-post

Yoast Duplicate Post plugin for WordPress
https://yoast.com
GNU General Public License v2.0
46 stars 36 forks source link

Scheduled posts using the Rewrite & Republish feature in Yoast Duplicate Post show as a 404 for Jetpack email subscribers and ConvertKit #358

Open josevarghese opened 8 months ago

josevarghese commented 8 months ago

Issue moved from GitHub: https://yoast.atlassian.net/browse/IM-874 Reporter: Michael Brian Tina

Please give us a description of what happened

When you use the Rewrite & Republish feature in Yoast Duplicate Post v4.1.1 and schedule a post, once the post has been republished, those subscribed through email (via Jetpack) receive an email of the new post. The URL in the email leads to a 404.

I tried testing this on one of my websites initially (disabling all plugins except for Jetpack and reverting to a default WordPress theme) and created a new post and published it normally. On one of my subscribed email addresses, I then received an email linking to the new post. It was showing the /?p=208 URL but when clicked on, it loaded the post just fine. screenshot-mail google com-2021 02 09-10_54_24

I then used the Rewrite & Republish feature on the same post and scheduled it for a few minutes later. Once it republished, I then received another email from Jetpack linking to the modified post. screenshot-mike checkthelatest com-2021 02 09-10_55_10 screenshot-mail google com-2021 02 09-10_56_52

However, when you click on the URL, it loads a 404 instead of the correct post. Screen Shot 2021-02-09 at 11 25 35 AM

To Reproduce

Step-by-step reproduction instructions

This text is here if the information was not retained when moving the issue.

Expected results

To show the correct link on the email

Actual results

For websites that use the Jetpack email subscription, their users would receive a 404 instead of a link to the post, which would affect their experience as a subscriber.

Screenshots, screen recording, code snippet

If possible, please provide a screenshot, a screen recording or a code snippet which demonstrates the bug.

Technical info

Used versions

josevarghese commented 8 months ago

Comments moved from Jira:

Jannes (February 19, 2021 at 6:00 PM) I have confirmed this. The cause seems to be that Jetpack hooks into the publication of the temporary “rewrite & republish” post, which is never actually published. It’s unclear where jetpack hooks in here, but that is the reason it gets the wrong URL.

Not sure if this is up to us to fix.

michaelbriantina February 11, 2021 at 1:59 PM

@Jannes I clicked on the link from the Jetpack email (which was my Gmail) and then opened the Ayima extension, so I’m guessing that’s where that redirect is coming from.

If I copy the URL http://mike.checkthelatest.com/?p=212 and just enter it into a new browser, it will still load as a 404.

Jannes (February 11, 2021 at 1:49 PM) @michaelbriantina why is there a Google redirect in one of your screenshots?

michaelbriantina (February 10, 2021 at 1:35 PM)

https://wordpress.org/support/topic/rewrite-republish-option-showing-404-page/

michaelbriantina (February 10, 2021 at 1:35 PM) When initially publishing the post normally (with only Jetpack enabled), Jetpack sends out an email with these links:

http://mike.checkthelatest.com/?p=208

http://mike.checkthelatest.com/r-r-test-3/

When clicked on, these load the page correctly.

Then I enabled the Yoast Duplicate Post plugin and used the Rewrite & Republish function on that same post, and made a few changes to the content, then scheduled it for a few minutes later. Once it republished, Jetpack sends out an email with these links: http://mike.checkthelatest.com/?p=212 http://mike.checkthelatest.com/?p=212 When clicked on, these load a 404.

Jannes (February 9, 2021 at 5:54 PM) I am not yet convinced this is our issue instead of Jetpacks… What is the exact URL that the link in the mail is referring to?

josevarghese commented 8 months ago

+1 https://wordpress.org/support/topic/email-has-wrong-link/

josevarghese commented 8 months ago

Please inform the customer of conversation # 1071436 when this conversation has been closed.

roo2 commented 7 months ago

Hi guys, I work at Automattic (not Jetpack exactly but the parent company) I think we spoke to the same user who found this issue, he raised it with us as well. I created an issue on the Jetpack side here https://github.com/Automattic/jetpack/issues/35099 but it's still unclear who is best placed to prioritize and fix this issue (and I can't speak to that as I'm not part of the Jetpack team)

Pcosta88 commented 5 months ago

Hey Guys,

I've mentioned this before I think but one theory we have is that the republished post appears on the RSS feed with it's republished URL (be it a -2 or that ?p=) for like a millisecond which is enough time for the newsletters tools to find it and then kick out an email.

The post then gets published so when users click the link in the email it goes to a 404.

shabnam611 commented 3 months ago

+1 https://wordpress.org/support/topic/incorrect-id-number-link-for-republished-posts/

From the user: error message appears that says the link doesn’t work even though it still uses the original URL