Add specs for Researcher and getStemmer - Githubissues

Yoast / javascript

Monorepo for all the JavaScript within Yoast

131 stars 54 forks source link

Add specs for Researcher and getStemmer #1106

Closed hannaw93 closed 3 years ago

hannaw93 commented 3 years ago

Summary

This PR can be summarized in the following changelog entry:

[yoastseo] Adds unit tests for the Czech Researcher and the Czech getStemmer file to confirm that the keyphrase and readability assessments work as expected.

Relevant technical choices:

Test instructions for Lingo team

This PR can be tested by following these steps:

Comment out lines of the code that import the morphology data file and test the stemmer (they and getStemmerSpec are failing until this PR is merged and the morphology data is available)
Run yarn test for the researcherSpec file.
If the test for "returns false if the default research is deleted in the Czech Researcher" fails, make sure that this PR is merged and that the feature branch is pulled from prior to testing.

Impact check

This PR affects the following parts of the plugin, which may require extra testing: *

UI changes

[ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

[x] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended

Fixes https://yoast.atlassian.net/secure/RapidBoard.jspa?rapidView=80&projectKey=LINGO&modal=detail&selectedIssue=LINGO-699

iolandasequino commented 3 years ago

CR: I edited a couple typos and changed the Czech locale to cs Acceptance: 👍