Replace OK by a green checkmark - Githubissues

Yoast / javascript

Monorepo for all the JavaScript within Yoast

131 stars 54 forks source link

Replace OK by a green checkmark #1150

Closed johannadevos closed 3 years ago

johannadevos commented 3 years ago

Summary

This PR can be summarized in the following changelog entry:

[@yoast/schema-blocks] Replaces OK in the sidebar by green checkmarks.

Relevant technical choices:

*

Test instructions

This PR can be tested by following these steps:

Add a Job Posting block and inspect the sidebar.
See that, for empty blocks, a green checkmark is shown that is roughly equal to the checkmark in the designs.
- It has been agreed that it's okay that the checkmark doesn't look like the design 100%.

Impact check

This PR affects the following parts of the plugin, which may require extra testing: *

UI changes

[x] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

[x] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended

Fixes #

andizer commented 3 years ago

CR + Acceptance 👍