Added warning block to list of blocks who should inherit the sidebar - Githubissues

Yoast / javascript

Monorepo for all the JavaScript within Yoast

131 stars 54 forks source link

Added warning block to list of blocks who should inherit the sidebar #1163

Closed hansjovis closed 3 years ago

hansjovis commented 3 years ago

Summary

This PR can be summarized in the following changelog entry:

[@yoast/schema-blocks] Fixes a bug where the sidebar of the warning block would not show the schema blocks sidebar elements.

Relevant technical choices:

Moved the call to registerInternalBlocks down, such that the warning block is registered after the filter has been added.

Test instructions

This PR can be tested by following these steps:

Create a post.
Add a job posting.
Remove a required or recommended block.
- A warning should appear in place of the removed block, with the question if you really want to remove the block.
Select the warning block.
The warning block's sidebar should contain the schema block sidebar elements.
- E.g. the analysis and the list of required and recommended blocks.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:
- N/A.

UI changes

[ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

[x] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended

Fixes #