P2 877 fix jobs html - Githubissues

Yoast / javascript

Monorepo for all the JavaScript within Yoast

131 stars 54 forks source link

P2 877 fix jobs html #1178

Closed andizer closed 3 years ago

andizer commented 3 years ago

Summary

This PR can be summarized in the following changelog entry:

[@yoast/schema-blocks] Provides a way to set the tagName that is used to render the value in the select instruction.
[@yoast/schema-blocks] Removes the div as wrapping element of the value that is set in the date instruction.

Relevant technical choices:

*

Test instructions

This PR can be tested by following these steps:

Test this together with https://github.com/Yoast/wordpress-seo-premium/pull/3297

Impact check

This PR affects the following parts of the plugin, which may require extra testing: *

UI changes

[ ] This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

[x] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended

Fixes #

johannadevos commented 3 years ago

Acceptance: ✅ (see Yoast/wordpress-seo-premium#3297)