Closed hansjovis closed 3 years ago
CR: ✅
innerBlocksSidebar
has been renamed to SchemaAnalysis
.SchemaAnalysis
, there are no occurrences of the strings parent
or clientId
.getRequiredBlockNames
and getRecommendedBlockNames
return a hard-coded array of block names and these arrays are complete.getValidationsForBlockNames
(previously getInnerblockValidations
) has been rewritten to no longer use the parent clientId
and directly return the array of BlockValidationResult
s for the job posting blocks.innerBlocks
instruction.I do see a couple of issues which will need to be split out to new tickets:
inheritSidebar
instruction. These will need to be removed. Many functions might need to be renamed (for example sidebarWarningPresenter
- maybe we can just call it warningPresenter
and leave the location unspecified).useValidationResults
in SchemaAnalysis.tsx
passes all the block names from the Yoast SEO Schema store to the getValidationsForBlockNames
selector. This will become a problem when we have multiple structured data blocks (the analyses will become mixed up). The Schema analysis should apply to each of the (structured data blocks-related) graph pieces in turn. But I think we best leave this until the moment we add a new structured data block. There are some UX questions about this.Merging despite the failing build, because the failing unit test is in another package (yoastseo
) and unrelated to our PR.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Impact check
UI changes
Quality assurance
Fixes #