search

Yoast / javascript

Monorepo for all the JavaScript within Yoast
131 stars 54 forks source link

Move A11yNotice out of the tests folder #237

Open igorschoester opened 5 years ago

igorschoester commented 5 years ago

Explanation

A11yNotice is a styled component, not a test helper. It is located in the src/tests folder and should be just in src.

Technical decisions

Feedback?

abotteram commented 5 years ago

I think it has to do with the fact that they have been moved to separate packages.

My hypothesis is that jest-styled-components behaves differently in regard to relative imports than in regard to @yoast/* imports. It would make sense that jest-styled-components doesn't care about "external" packages.

igorschoester commented 5 years ago

Good point, maybe it is fine. Still would be nice to be confirmed though. And the moving out of the test folder still remains.

igorschoester commented 5 years ago

As discussed with Anton, repurposing this PR for only the first point (moving from the test folder).

The second (no A11yNotice styled components output in snapshots) is no longer important enough. It might be expected behavior as Alexander says above. Or it may even be fixed within jest-styled-components itself if it is a styled-components v4 issue.