Add default values Social Previews - Githubissues

Yoast / javascript

Monorepo for all the JavaScript within Yoast

131 stars 54 forks source link

Add default values Social Previews #631

Closed maartenleenders closed 4 years ago

maartenleenders commented 4 years ago

Make sure the reactified social previews have the same default values as the old social previews. Currently, they are loaded in empty, which looks bad.

When the values are set (so non-default values), they should ofcourse immediately be loaded into the preview.

Make sure that the default value only appear in the Social Form, not in the actual input fields.

To do

[ ] Copy the behavior of the old social previews
[ ] If the old social previews have a situation where the previews would be empty, make sure it will show a default in the new ones.

maartenleenders commented 4 years ago

Test these together for this issue: (do a quick test in free before testing the rest in premium).

https://github.com/Yoast/javascript/pull/659 https://github.com/Yoast/wordpress-seo/pull/15088 https://github.com/Yoast/wordpress-seo-premium/pull/2772