search

Yoast / javascript

Monorepo for all the JavaScript within Yoast
131 stars 54 forks source link

Move LinkSuggestions files to @yoast/link-suggestions package #90

Open LisanneKluitmans opened 5 years ago

LisanneKluitmans commented 5 years ago

Summary

We want to have structured packages for all our components. To achieve this, we need to move the LinkSuggestions files to a new package.

Explanation

These KeywordSuggestions files need to be moved to the new @yoast/link-suggestions package: javascript/packages/yoast-components/composites/LinkSuggestions/

Technical decisions

The version of this new package needs to be 0.1.0

Feedback?

andizer commented 5 years ago

I have some thoughts about this component, because it is doing too much at the moment:

  1. It has knowledge of the cornerstone functionality in the plugin.
  2. It is classifying suggestions based on being cornerstone or not.
  3. It shows a introduction text that should be in the plugin
  4. The clipboard is loaded in the state and that shouldn't be the case.

I think this has to be changed:

  1. The plugin should check if it is cornerstone or not.
  2. If there are two types of linksuggestions we should render the component two times.