search

Yoast / wordpress-seo

Yoast SEO for WordPress
https://yoast.com/wordpress/plugins/seo/
Other
1.78k stars 895 forks source link

BuddyPress members and groups page's meta data & noindex, nofollow not added to pages source code #12435

Closed msteimann closed 5 years ago

msteimann commented 5 years ago

Please give us a description of what happened.

BuddyPress setup works by creating two blank pages – members and groups. If I type in a meta description in Yoast for both and preview the pages, the description text is added to the page header and gets properly displayed in the page source text.

But as soon as I assign the two pages to the BuddyPress plugin, the description gets stripped completely. In the page source appears an author note that a description needs to be added.

Yoast settings „noindex, nofollow“ are stripped, too.

The BBpress Forum page is not affected by this issue. Yoast can apply a meta description and the „noindex, nofollow“ command, which is a good thing.

Please also note: https://wordpress.org/support/topic/severe-buddypress-conflict/

Please describe what you expected to happen and why.

Yoast settings should reflect in any page source code with no exception.

How can we reproduce this behavior?

  1. Please create two blank pages yourself and name them „members“ and „groups“.
  2. Go to the WP dashboard – settings – BuddyPress and check all items in the „component“ tab. Then move to the third tab „pages“ and assign (chose from the drop-down-menue) your newly created pages to „members“ and „groups“. That’s it.
  3. If you add to both pages a meta description in Yoast and set index and follow to your needs, these additions do not reflect in the source text of the pages. They are simply not present at all.

Technical info

Djennez commented 5 years ago

I got around to testing this and was able to reproduce this with: Yoast 10.1.2 BuddyPress 4.2.0 Query Monitor (QM) 3.3.4

Are you running QM by any chance? I found that disabling QM solved the issue for me. Debugging the code we found that the page ID in memory was set to 0 when BuddyPress and QM were running at the same time. This caused issues for our plugin.

Please let me know if you run QM and if so, if the problem recedes when you disable that plugin. If you don't run QM, try disabling all other plugins to see if this solves the problem somehow.

Edit: Somehow, now QM does not seem to be the culprit. Investigating further.

Edit 2: The issue seems to lie with BuddyPress. They add an action to do_action( 'template_redirect' ); in WordPress's template-loader.php which results in the ID in memory being set to 0 after this step. This causes problems for our plugin further down the line. I'd advise you to contact their support to have a look at this.

msteimann commented 5 years ago

Hello Djennez,

thank you for testing this. I followed your advice and disabled all plugins, but the issue remains (as you have found out yourself while I was testing it).

I have already contacted the BuddyPress support and they told me to contact the YOAST support. Please read: https://buddypress.org/support/topic/severe-buddypress-yoast-conflict/#post-303355

I found this thread some time ago but do not have any coding skills: https://buddydev.com/making-wordpress-seo-plugin-compatible-with-buddypress/

So I was hoping for a constant fix either from the Yoast- or BuddyPress-Team. Maybe you could get in touch and work this out together? Sure you would make ton of people happy!

Regards, Martin

msteimann commented 5 years ago

I have just raised the issue on Wordpress Trac system:

https://buddypress.trac.wordpress.org/ticket/8078#ticket

Djennez commented 5 years ago

I'm going to close this thread as in active and it seems that BuddyPress is not able to fix this (on short notice) on their part. If there are any more questions, feel free to leave a comment.