search

Yoast / wordpress-seo

Yoast SEO for WordPress
https://yoast.com/wordpress/plugins/seo/
Other
1.75k stars 886 forks source link

Bug with Russian translation #13186

Closed Arskrigitsioniets closed 5 years ago

Arskrigitsioniets commented 5 years ago

Please give us a description of what happened.

There is a missed translation of the strings in Gutenberg editor on Russian language when YOAST Seo and Event Calendar Wd both are activated: – Drag an image, upload a new one or select a file from your library. – Upload – Media Library – Insert from URL Adding new block, strings: – Most used – Reusable Block menu: – More rich text controls button – More options button: Duplicate, Insert Before, Insert After, Edit as HTML, Add to Reusable Block, Remove block Screenshot: https://imgur.com/kxXN1Wd Important: Polylang doesn't detect these strings and says that 100% translated in

How can we reproduce this behavior?

  1. Install Russian version of Wordpress
  2. Install YOAST Seo and Event Calendar Wd
  3. Activate both plugins
  4. Go to post editor and see missed translation strings

Technical info

Djennez commented 5 years ago

Hi @Arskrigitsioniets, I fail to see how this is a Yoast-related bug, as the strings in your screenshot are core-WordPress strings. Could you elaborate this a bit more?

Arskrigitsioniets commented 5 years ago

Please, check the second post in this thread: https://wordpress.org/support/topic/bug-with-russian-translation/#post-11687561 Developers of Event Calendar reproduced this bug and recorded it. They speak that it's a problem with YOAST Seo.

Djennez commented 5 years ago

Hmmm, I'm not able to reproduce this. I don't think this is a Yoast, or plugin, related issue. Have you downloaded all up to date translation files (Dashboard -> Updates -> Translations)?

Arskrigitsioniets commented 5 years ago

Yes, all translations are updated. I was able to reproduce it in a clear new WordPress site. Maybe you can try with Baskerville theme.

Arskrigitsioniets commented 5 years ago

Here is my video in which I reproduce the bug on a clear new site: https://youtu.be/ZXnJLUydLUM Take you attention on "Most used" string in 1:28 that missed the translation, It repairs after I disabled YOAST seo later.

Djennez commented 5 years ago

I get that this looks like it might be Yoast related. But I fail to see how it actually is. We don't do anything with these translations and I am also unable to reproduce the issue with your exact steps:

image This has WD Events and Yoast enabled and it shows Russian titles.

Looking at the Gutenberg repository, there have been issues with the same results as what you describe. Have a look at https://github.com/WordPress/gutenberg/issues/12979 for example. That issue was solved in WordPress 5.0.2 and was about WordPress installations in subdirectories. Your issue probably has a different cause but almost the same symptoms. It might be related to Punycoding? I don't know.

I'll ask around here and try to run some more tests, but I'm afraid this is not something we would be able to fix.

Djennez commented 5 years ago

I am going to close this issue as it does not seem to be something that is caused by our plugin. I would advise searching the issues on the Gutenberg repository or share this issue there, to see if it might be something Gutenberg related.

Of course, if you believe this is Yoast related, please share your thoughts on the how and why.