Grunt build removes focusable="false" from SVG's - Githubissues

Yoast / wordpress-seo

Yoast SEO for WordPress

https://yoast.com/wordpress/plugins/seo/

Other

1.78k stars 894 forks source link

Grunt build removes focusable="false" from SVG's #13791

Closed hwinne closed 5 years ago

hwinne commented 5 years ago

[x] I've read and understood the contribution guidelines.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

Running Grunt build removes the focusable="false" attribute from four SVG's:

This issue seems to be similar: https://github.com/Yoast/wordpress-seo/issues/12654 related PR: https://github.com/Yoast/wordpress-seo/pull/12827

Please describe what you expected to happen and why.

Focusable="false" is an accessibility feature which should not be removed.

How can we reproduce this behavior?

Checkout trunk
run grunt build
See and compare the svg-code of the affected code (git s to see changes)

Technical info

The four affected SVG's are:

local_plugin_assistant.svg
news_plugin_assistant.svg
video_plugin_assistant.svg
woo_plugin_assistant.svg

Used versions

WordPress version: 5.2.4
Yoast SEO version: 12.5-RC2
Tested with theme: Twenty Nineteen

johannadevos commented 5 years ago

focusable=false isn't removed, but rather it is moved a bit further down. However, I also saw other (numeric) changes between the two versions of the .svg files.