stodorovic
commented
5 years ago Related to sitemaps, it's more general issue. Example of the content:
[et_pb_row]
[et_pb_column]
[et_pb_text]
<p>[gallery link="file" size="full" ids="4392,4393" orderby="rand"]</p>
[/et_pb_text]
[/et_pb_column]
[/et_pb_row]
[/et_pb_section]It's fixed in #13797, but because Divi builder runs all shortocodes in the content, their developers should exclude gallery from the filter _wpseo_sitemap_content_before_parsehtml. It's better for performance, because _WPSEO_Sitemap_ImageParser will use faster way to extract image IDs and 3rd plugins will not make mess in the code (lazy loading,...) which could block parsing.
Example of optimized code includes/builder/plugin-compat/wordpress-seo.php:
/**
* Hook methods to WordPress
* Latest plugin version: 3.1.1
* @return void
*/
public function init_hooks() {
// Bail if there's no version found
if ( ! $this->get_plugin_version() ) {
return;
}
// Enable Sitemap Cache
add_filter( 'wpseo_enable_xml_sitemap_transient_caching', '__return_true' );
add_filter( 'wpseo_build_sitemap_post_type', array( $this, 'load_builder_modules_early' ) );
}
/**
* Loads the builder's modules so that they are loaded before Yoast generates the sitemap.
*
* @param string $type
*/
public function load_builder_modules_early( $type ) {
// Removes filters for "responsive images". It isn't needed for sitemaps.
remove_filter( 'wp_calculate_image_srcset', 'et_filter_wp_calculate_image_srcset', 10, 4 );
remove_filter( 'wp_calculate_image_sizes', 'et_filter_wp_calculate_image_sizes', 10, 4 );
remove_action( 'wp', 'et_builder_init_global_settings', 9 );
remove_action( 'wp', 'et_builder_add_main_elements' );
et_builder_init_global_settings();
et_builder_add_main_elements();
add_filter( 'pre_do_shortcode_tag', array( $this, 'exclude_gallery_shortcode' ), 10, 4 );
add_filter( 'wpseo_sitemap_content_before_parse_html_images', array( $this, 'do_shortcode' ) );
return $type;
}
public function exclude_gallery_shortcode( $content, $tag, $attr, $m ) {
if ( $tag === 'gallery' && $this->preserve_gallery_shortcode ) {
$content = $m[0];
}
return $content;
}
public function do_shortcode( $content ) {
// Check if content includes ET shortcode.
if ( false === strpos( $content, '[et_pb_section' ) ) {
// None found, bye.
return $content;
}
// Render the shortcode.
$this->preserve_gallery_shortcode = true;
$content = apply_filters( 'the_content', $content );
$this->preserve_gallery_shortcode = false;
return $content;
}Removing filters related to processing srcset and sizes could reduce number of SQL queries. From other side, the sitemap's code uses only src attribute. It could be little optimization related to Divi builder. @lots0logs Could you look it?
lots0logs
Pcosta88
monbauza
rmarcano
suascat
rumejan
maybellyne
DavidSaladu
jeroenrotty
Please give us a description of what happened.
Images added by Divi Image or Gallery Module fail to be picked-up scanned parsed by Yoast and do not show on sitemap
Please describe what you expected to happen and why.
As per this issue report https://github.com/Yoast/wordpress-seo/issues/4808 they would (or at least the image module should)
How can we reproduce this behavior?
1. Add an image using Divi Gallery Module or Image
Gallery
Image
2. Run webworker tool on it and see it only picks up the text
3. Check sitemap and see that it fails to appear
Technical info
Used versions