Yoast / wordpress-seo

Yoast SEO for WordPress
https://yoast.com/wordpress/plugins/seo/
Other
1.78k stars 894 forks source link

Add actionable button to SKU assessment #19866

Closed manuelaugustin closed 1 year ago

manuelaugustin commented 1 year ago

Moved from: https://yoast.atlassian.net/browse/PC-544

What is the goal of this issue?

What needs to be done to achieve the goal?

See expected result.

Does the issue still need UX or research?

No.

If available: what are the tips for fixing the problem or possible solutions?

See PR in which actionable buttons were originally implemented: https://github.com/Yoast/wordpress-seo/pull/18674

What is the expected result/behavior?

No product variants

SKU_no_variants SKU_field

Product with variants

SKU_variants variants-2 first_variant

Shopify

We don't have support for actionable buttons in Shopify yet.

Should documentation be added or updated for this change? and if so, where?

We should update the feedback strings in the documentation about the SKU assessment.

hdvos commented 1 year ago

Found an issue during acceptance testing. See this report in the PR https://github.com/Yoast/wordpress-seo/pull/19886#pullrequestreview-1348221061

FAMarfuaty commented 1 year ago

Found an issue during acceptance testing. See the Slack message.

mykola commented 1 year ago

@FAMarfuaty good catch. Thanks. I have fixed it.

hannaw93 commented 1 year ago

CRed but not fully reviewed and accepted yet due to a testing env issue (and it being handly to look at the code while testing for the woocommerce PR). When testing, pay extra attention to behaviour mentioned in comment: https://github.com/Yoast/wordpress-seo/pull/19886#pullrequestreview-1348221061