Squirrly SEO import outputs a database error

pls78 commented 1 year ago

[x] I've searched for any related issues and avoided creating a duplicate issue.
[x] Roadmap issue: #

Please give us a description of what happened

When trying to import data from Squirrly SEO plugin, the process terminates with a successful message but a database error is shown, too.

To Reproduce

Step-by-step reproduction instructions

Install and activate Yoast SEO
Install and activate Squirrly SEO
Go to Yoast SEO -> Tools -> Import and Export -> Import from other SEO plugins tab
In step 2, choose Squirrly SEO from the drop-down menu and click on Import

Expected results

No errors should be printed

Actual results

A database error is shown

Screenshots, screen recording, code snippet

If possible, please provide a screenshot, a screen recording or a code snippet which demonstrates the bug.

Technical info

If relevant, which editor is affected (or editors):
[ ] Block Editor
[ ] Gutenberg Editor
[ ] Elementor Editor
[ ] Classic Editor
[ ] Other:

Which browser is affected (or browsers):
[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Other:

Used versions

Device you are using: MacBook Pro
Operating system: MacOS 12.5
PHP version: 7.4.30
WordPress version: 6.1.1
WordPress Theme: twentytwentytwo
Yoast SEO version: 20.1 (production)
Yoast SEO Premium version: N/A
Gutenberg plugin version:
Elementor plugin version:
Classic Editor plugin version:
Relevant plugins in case of a bug: Squirrly SEO (Peaks) 12.1.20

oksanayoast commented 1 year ago

It's not only an error, SEO data import from the Squirrly SEO plugin doesn’t work at all

Step-by-step reproduction instructions

Install and activate Squirrly SEO
Create a post and some SEO data
Deactivate Squirrly SEO.
Install and activate Yoast SEO 20.2.1
Go to Yoast SEO -> Tools -> Import and Export -> Import from other SEO plugins tab
In step 2, choose Squirrly SEO from the drop-down menu and click on Import.
Go to the post and check if SEO data was actually imported

Expected results

SEO data is transferred to Yoast SEO Actual results

SEO data is NOT transferred to Yoast SEO. Database error.

leonidasmi commented 1 year ago

Without diving too much into the the issue and its potential culprits, I can say that we might consider completely moving the Squirrly import to the new way of import - they way that AIOEO v4 import is using.

Guesstimations here, since I have no context on the Squirrly issues currently, but I can confidently say that that would be:

less work than what AIOSEO needed (that's true because we have the backbone ready. but of course, it won't be insignificant work, especially if we want to map all the Squirrly settings to Yoast ones)
more work than what just fixing the current import needs

the upside of moving it to the new one is:

it won't need SEO optimization after import
it's (much, much) safer to use for bigger sites, performance-wise
probably also it will also take care of site-wide settings, instead of focusing only on post-specific ones (I assume that's the case with current Squirrly import)

monbauza commented 1 year ago

I ran a quick test and noticed that this issue also occurs with older versions of the plugin (tested with Yoast SEO v19.0). As we haven't received any reports/complaints from users so far regarding this, I'll give minor severity.

leonidasmi commented 1 year ago

@monbauza it would be interesting to see if it happens with older versions of the Squirrly SEO plugin as well.

I'm guessing that things started to break when they did a BC-breaking change in their plugin.

But yeah, not sure of its prio :)

monbauza commented 1 year ago

@leonidasmi I tested older versions of Squirrly, and it looks like the database error started to occur in Squirrly SEO 12.1.04 - released on May 24, 2022. The database error doesn't occur in Squirrly SEO 12.1.03 and previous versions.

leonidasmi commented 1 year ago

Awesome, thanks for that really useful info 🎉 🙂

shabnam611 commented 6 months ago

I performed a test and noticed with the free version of Yoast SEO 22.1, the database error doesn't show up. However, I can see the metadata is not being imported as mentioned by oksanayoast earlier.

I was using Yoast SEO 22.1, Squirrly SEO v12.3.17 and WordPress 6.4.3.