Yoast / wordpress-seo

Yoast SEO for WordPress
https://yoast.com/wordpress/plugins/seo/
Other
1.76k stars 885 forks source link

Missing meta data on The Events Calendar taxonomy pages #20306

Open josevarghese opened 1 year ago

josevarghese commented 1 year ago

Issue moved from Jira: https://yoast.atlassian.net/browse/IM-1349 Reporter: @amboutwe

Please give us a description of what happened

The Events Calendar provides a custom taxonomy called 'Event Categories'. The Yoast SEO meta data does not use the default templates for title or description. Therefore, the metadata (Open Graph, Twitter, schema) is not generated correctly.

Workaround Add custom title and description in the metabox for each category. This should fix almost all of the incorrect data. The title tag remains wrong even with a custom title in the metabox. The schema may need additional code (example).

Related https://github.com/Yoast/wordpress-seo/issues/17006 https://github.com/Yoast/wordpress-seo/issues/16664 https://wordpress.org/support/topic/how-to-update-title-tags-in-yoast/ https://github.com/Yoast/wordpress-seo/issues/1362

To Reproduce

Step-by-step reproduction instructions

Starting with a vanilla installation:

  1. Install and activate The Events Calendar
  2. Go to Admin > Events > Event Categories
  3. Add two parent categories called 'Default' and 'Metabox' (naming will help later)
  4. Install and activate Yoast SEO (free)
  5. View the event category page source for both categories. Notice that the page has no description and the title is Upcoming Events %%sep%% %%sitename%%
  6. Go to Admin > Yoast SEO > Settings > Categories & Tags
  7. Expand 'Event Categories (tribe_events_cat)' and add or change the templates so both fields have a custom default.
  8. View the event category page source for both categories. Notice that the description and title are unchanged; i.e. ignoring the default option.
  9. Edit the 'Metabox' category and add a custom post-level title and description for the category.
  10. View the event category page source for 'Metabox'. Notice that the empty description warning is replaced with the post-level description, but the title remains unchanged (wrong).

Expected results

Title, meta description, social and schema would be correct.

Actual results

Parts are missing which cascades to more missing data.

Impact Everyone that uses The Events Calendar and Yoast SEO. Causes errors in GSC (missing name in schema). Causes unexpected information to appear in SERPs.

Screenshots, screen recording, code snippet

If possible, please provide a screenshot, a screen recording or a code snippet which demonstrates the bug.

Technical info

Used versions

josevarghese commented 1 year ago

Comment: @monbauza (Ramon Bauza) September 27, 2021 at 2:40 PM

When investigating this, I noticed that the Term title variable isn't output in the source code when using the workaround for meta descriptions.

josevarghese commented 1 year ago

Please inform the customer of conversation # 1014089 when this conversation has been closed.

josevarghese commented 1 year ago

Please inform the customer of conversation # 911668 when this conversation has been closed.

josevarghese commented 1 year ago

Please inform the customer of conversation # 823149 when this conversation has been closed.