Yoast / wordpress-seo

Yoast SEO for WordPress
https://yoast.com/wordpress/plugins/seo/
Other
1.78k stars 894 forks source link

'wpseo_posts_where' filter should default to empty string instead of false? #20357

Open DrLightman opened 1 year ago

DrLightman commented 1 year ago

Hello team,

the filter to extend the where sql clause in sitemap:

'where' => apply_filters( 'wpseo_posts_where', false, $post_type ),

Shouldn't the false be an empty string like it is in the similar 'wpseo_typecount_where' filter?

$where_filter = apply_filters( 'wpseo_typecount_where', '', $post_type );

It's a minor thing, just a formality maybe.

Thanks.

jeroenrotty commented 1 year ago

I talked to one of our devs internally and they agree that this is a point where we can improve. I've added to the backlog of issues for now. Thank you for letting us know.