Open menno-ll opened 7 months ago
Hi @menno-ll
Thanks for using the Yoast SEO plugin and for creating the PR. Our development team will review the PR you have provided and will keep you posted.
Hi @josevarghese , Unfortunately the PR has not yet been approved and merged. I received a suggestion, made a modification, re-requested a review and then the reviewer unassigned himself. And since then, nothing happened. Is there a possibility to have someone re-review it?
Please note this problem is also present in the premium version in the plugin. I'm not quite sure how changes from the free plugin are ported to the premium one, so might need to copy the solution over to there as well.
Thanks in advance!
Please give us a description of what happened
Yoast uses the shutdown hook in class-yoast-notification-center.php to perform some stuff. Inside the callback function, Yoast will use some wordpress functions. If there is a plugin that calls the exit() function on the plugins_loaded hook, this would result in an error, which i will place below.
The reason this happens, is that WordPress loads it's pluggable.php file later than the plugins_loaded hook. And therefore, it's not loaded at this stage.
The fix should be quite simple. By adding
require_once ABSPATH . 'wp-includes/pluggable.php';
to the shutdown callback function, this issue can be resolved. I will make a PR to resolve this issue.To Reproduce
Step-by-step reproduction instructions
Expected results
Actual results
Screenshots, screen recording, code snippet
If possible, please provide a screenshot, a screen recording or a code snippet which demonstrates the bug.
Technical info
Used versions