Yoast / wordpress-seo

Yoast SEO for WordPress
https://yoast.com/wordpress/plugins/seo/
Other
1.78k stars 894 forks source link

yoast/video-seo 14.9 is missing from Yoast composer repository #21648

Open nlemoine opened 2 months ago

nlemoine commented 2 months ago

Please give us a description of what happened

While upgrading a project, I faced an issue with composer/installers. yoast/video-seo:<=14.8 is still requiring composer/installers:^1.12.0 which conflicts with a dependency I have that requires composer/installers:^2.0.

I checked the yoast/video-seo changelog and saw that 14.9 adresses this issue.

As you probably guessed, I'm using composer to manage my stack and started to wonder why composer didn't upgrade yoast/video-seo to 14.9 automatically as it should have.

After a quick check, seems like 14.9 isn't released in your repository.

Note I tried first to reach out Yoast support, providing all those details and got a "How to install Yoast plugins using composer" link as a feedback 🙄. Hence the GitHub issue in the hope to reach the technical team.

To Reproduce

Step-by-step reproduction instructions

  1. http -a token:{my_premium_token} https://my.yoast.com/packages/p2/yoast/wpseo-video.json (using httpie)
  2. Check the JSON response, the latest version is 14.8, 14.9 is missing.

Expected results

Up to date composer repository.

Actual results

Stuck at 14.8, which means all composer users didn't get the update that has been released since May 28.

Used versions

josevarghese commented 1 month ago

Hi @nlemoine

Thanks for using the plugin and for creating the issue. We are able to replicate that the latest version of Yoast Video SEO plugin not available on the composer as you have mentioned. We are now in contact with our development/devops team and we hope to fix it ASAP.

We will keep you posted once we get an update.

Sorry for the inconvenience caused.

josevarghese commented 1 month ago

Hi @nlemoine

Update for you: We have noticed a deployment failure for the Yoast Video SEO caused this. We have fixed the issue at our end for future updates of the Yoast Video SEO plugin, and we are working to find out how to update the Yoast Video SEO 14.9 without another release process.

nlemoine commented 1 month ago

Thank you @josevarghese for keeping me posted. Let me know when the package is available in your composer repo.

nlemoine commented 1 month ago

Hi @josevarghese,

Any news about this? I'm waiting for a fix to deploy a project that needs composer/installers: ^2.0 🙏

nlemoine commented 2 weeks ago

@josevarghese, it's been more than a month since I opened this issue and more than five months that customers using composer don't get the updates. I also have a premium subscription and would expect a bit more reactive support from you.

Furthermore, it's not a hard thing to tackle.

Can you set a higher priority to this issue please?

josevarghese commented 2 weeks ago

Hi @nlemoine

As mentioned before, a new release (with a higher number of versions) needs to be rolled out to fix this issue. According to the developer's and DevOps team's messages, there is no manual option to update a version for the composer which we have already released.

nlemoine commented 2 weeks ago

Then bump a dummy patch number? 14.9.1

According to the current release pace, this might take months!

josevarghese commented 2 weeks ago

But that bump will cause to show an update to all the users of the Yoast Video SEO plugin that we have released a version :(

nlemoine commented 2 weeks ago

I also encounter many warnings with video seo (undefined player_loc key flooding my logs).

There are many good reasons to release a new version.

josevarghese commented 2 weeks ago

Thanks for getting back to us. Can you please contact the support team about the undefined player_loc key issue and other issues you notice after updating the Yoast Video SEO plugin to the latest version, 14.9, via FTP?

So that our team can take a closer look into this.

nlemoine commented 2 weeks ago

But that bump will cause to show an update to all the users of the Yoast Video SEO plugin that we have released a version :(

It's plugin life cycle, the last one was in May, nothing to be afraid of.

after updating the Yoast Video SEO plugin to the latest version, 14.9, via FTP?

As mentioned before, my stack is composer based so I had to create a private repo and upload the plugin to that repo to be able to have 14.9.

josevarghese commented 2 weeks ago

The next release may take some time as the development team is working on it, and there's no ETA to share with you. However, I have shared this concern with the development team.

nlemoine commented 2 weeks ago

Thanks for your feedback @josevarghese.

It's a really a shame that you can't fix this issue without releasing a new version. I mean, that file is on a server somewhere. If it can't be fixed afterwards, there's a serious issue with your DevOps process.

Also understand that your answer "wait until the next release" is bit confusing, considering that the latest tag is missing since more than 6 months.

Further more, if I summarize the video-seo plugin changelog, I notice that releases do not happen that often. Am i supposed to wait for another year for a trivial issue to be fixed while having a premium subscription? 😕

Version Release Date
14.9 May 28, 2024
14.8 August 8, 2023
14.7 March 14, 2023
14.6 July 12, 2022
14.5 May 6, 2022
14.4 April 19, 2022
14.3 January 25, 2022

I hope the ETA will not be too long and I'd really like Yoast to set a high priority on this. Here's at least two things you can fix in the next release. I post them here because the support doesn't help or just repeats what's been said ("wait for the next release").

Warning: Attempt to read property "taxonomy" on null

Happens when requesting a tax term page with ?s and the term does not exist (which is both is_tax/is_tag/is_category and is_search and ends up with queried_object to be null)

Capture d’écran 2024-11-07 à 10 30 26

Warning: Undefined array key "player_loc"

Happens in RSS feed context, seems to be triggered when the video is self hosted.

CleanShot 2024-11-06 at 12 01 46

Thanks for understanding.

josevarghese commented 1 week ago

I have already mentioned why we cannot change this manually, as it's generated automatically when a new version is released. During the last release, an error occurred that prevented it from updating. Our team fixed it, as mentioned in the response above, and you need to wait for the next version to see this on the composer.

Regarding the other issue you have noticed, if you haven't yet opened a support ticket, kindly open a support ticket for our support team to look into this.

nlemoine commented 1 week ago

I have already mentioned why we cannot change this manually

Absolutely, I'm just pointing out that "Because it's automated, wait for another X months" isn't really a satisfying answer.

Regarding the other issue you have noticed, if you haven't yet opened a support ticket, kindly open a support ticket for our support team to look into this.

Sorry, I've already wasted too much time on this topic. This addon isn't reaching the quality it should.