search

Yoast / wordpress-seo

Yoast SEO for WordPress
https://yoast.com/wordpress/plugins/seo/
Other
1.76k stars 889 forks source link

Underlined link in "You still have the default WordPress tagline" notice #3969

Closed szepeviktor closed 8 years ago

szepeviktor commented 8 years ago

yoast

szepeviktor commented 8 years ago

in v3.1

Rarst commented 8 years ago

Coming from

.error a {
    text-decoration: underline;
}

in wp-admin/css/common.css

afercia commented 8 years ago

Underlined links within notices is the intended behavior in WordPress, see https://core.trac.wordpress.org/ticket/34606. By the way, the dismiss notice "X" in WordPress is a <button> element, so it doesn't inherit the underline. Worth noting in WordPress the dismiss buttons are generated via JS, all that's needed is to add the notice is-dismissible CSS classes to the notice, see makeNoticesDismissible() in WordPress common.js.

szepeviktor commented 8 years ago

I think in Yoast the X is not a button.

Rarst commented 8 years ago

Notices interface had been refactored since, no longer relevant.