Cannot edit Woocommerce Attributes: Uncaught TypeError: Cannot read property 'value' of null

[steve10287]

The is an issue that is preventing use of any popups within wordpress. Occurs when editing Woocommerce attribute images. I have to disable Yoast then edit the attribute image.

Thanks!

[Rarst]

Could you please try to disable other plugins to check for conflicts?

Also what are the exact steps to demonstrate the issue? Not very familiar with WooCommerce UI. :)

[steve10287]

Seems the conflict is with WooCommerce Variation Swatches and Photos

https://www.woothemes.com/products/variation-swatches-and-photos

I have linked this issue to their support team.

[edwinhamers]

Any news on this? I installed a new WP site; installed woocommerce, installed Yoast and installed Variation Swatches and Photos. When i try to add a taxonomy color the javascript html color picker does not work

• Uploading images not possible because the media popup will not appear. The page just reloads.

[steve10287]

No news yet, currently waiting on the developers for the plugin to respond, maybe you could also ticket them :)

[lucasstark]

@steve10287 The error occurs without WooCommerce Variation Swatches and Photos active. This only occurs when you choose to hide the Yoast SEO metabox from the product attribute.

[Rarst]

Product attributes is technically what, terms? If this is related to assets issues from disabling metabox on terms it should be fixed by #4170

[lucasstark]

@Rarst Yes, in WooCommerce, product attributes are just regular wp taxonomies.

[edwinhamers]

@lucasstark You are commenting "This only occurs when you choose to hide the Yoast SEO metabox from the product attribute"

I looked through the settings of Yoast SEO, but all my metaboxes are set to "Show". And still i cannot add swatch colors or photos in the woocommerce> variations.

[lucasstark]

@edwinhamers Try it without Variation Swatches and Photos active. The normal Add Media button on the description editor does not work.

[edwinhamers]

I just updated Yoast SEO, with the supposedly fix for the javascript bug 4167. But it has not solved my problems. I still get the Javascript error in the console.

@lucasstark I disabled Variation Swatches. Then i edit a product and try the "Add Media button". This does work for me. Or is that not what you meant? Or i go to Woocommerce > Variations > Variations type > Variation (like color red) and click the "Add media" button. That also works!

Console error: wp-seo-term-scraper-310.min.js?ver=3.1.2:1 Uncaught TypeError: Cannot read property 'value' of null

[lucasstark]

@edwinhamers You are mixing different things. Original problem is "The is an issue that is preventing use of any popups within wordpress. Occurs when editing Woocommerce attribute images. I have to disable Yoast then edit the attribute image."

@steve10287 Said it had to do with Variation Swatches and Photos, but after I checked I found it does not. The Add Media Button when you are editing a Product Attribute Description does not work, with our without Variation Swatches and Photos, so there is nothing I can fix on my side.

[edwinhamers]

@lucasstark : sorry for mixing it up. When i activate "Variations & Swatches" it cannot be used when Yoast is active. So i have to disable Yoast. So the problem is with Yoast SEO. I think i will file another issue then

[lucasstark]

@edwinhamers Right, there are also other issues that are present when Yoast SEO is active without any other plugin except Yoast SEO and WooCommerce. You can not "Add Media" from a Product Attribute. See: http://d.pr/i/16pu2.

[Rarst]

Okay, this got tad convoluted. :)

@steve10287 and @edwinhamers seems to both have issue with Variation Swatches and Photos enabled and not have issue with it disabled. Is this correct?

@lucasstark seems to claim this is more general issue, that can be demonstrated without his plugin enabled.

Can someone please provide step by step to demonstrate general issue here, without plugin involved? Without WooCommerce involved at all?

[edwinhamers]

@Rarst : Yes, this is an issue with Yoast SEO and not due to the Swatch&Variations plugin as mentioned by Lucas. But in my case it manifests in the Swatch&Variations plugin by disabling the upload button and the JS color picker. When i disable Yoast SEO i can use the Swatch plugin again.

So the JS error appears with other plugins also.

[edwinhamers]

https://github.com/Yoast/wordpress-seo/issues/4237#issuecomment-205227537

[Rarst]

If this is a conflict with single specific plugin then it is a conflict.

If it's a general issue then I need steps to reproduce it by itself, or at least with other plugin(s) as well.

[edwinhamers]

I can reproduce it with Woocommerce enabled & Yoast enabled.

In Woocommerce you go to Products > Attributes > Variations > Edit a variation. The the console will show the JS error.

@lucasstark mentioned this happened in other instances also, maybe he can comment on it.

[Rarst]

In Woocommerce you go to Products > Attributes > Variations > Edit a variation.

I don't see Variations step, something I need to do to have it appear, assuming start from blank WooCommerce install?

[edwinhamers]

@Rarst

Ok, from a blank woocommerce:

Products > Attributes > Add new atributes (for example "Colors) You can leave everything at default. The new attribute category will be added on the right. Click on the "gear icon" to edit the "Terms" Add a new term New term will be added on the right. Now edit the term. In the edit screen you can see the Console JS error

[Rarst]

Cannot reproduce, I get no JS error following your instructions on my dev install with WooComerce alone.

[edwinhamers]

@Rarst There are similar threads on the same topic : https://github.com/Yoast/wordpress-seo/issues/4237 https://github.com/Yoast/wordpress-seo/issues/4218

So which thread to use ?

[Rarst]

If @terw-dan is looking into it then listen to him over me, he is JS person. :)

[terw-dan]

I'm closing this issue in favor of https://github.com/Yoast/wordpress-seo/issues/4237 I've included a link to a beta of the upcoming release that fixes incompatibility with some plugins.