search

Yoast / wordpress-seo

Yoast SEO for WordPress
https://yoast.com/wordpress/plugins/seo/
Other
1.73k stars 881 forks source link

og:image filename including æøå #4404

Closed phh closed 7 years ago

phh commented 8 years ago

What did you expect to happen?

Sharing http://castus.dk/produkter/frugtpalaeg-med-kakao/ on Facebook should include the og:image (default set to featured image).

What happened instead?

The share box is using a blank/white image.

How can we reproduce this behavior?

Try to share this url on Facebook: http://castus.dk/produkter/castus-sport-banan-kakao/

Can you provide a link to a page which shows this issue? http://castus.dk/produkter/frugtpalaeg-med-kakao/ https://developers.facebook.com/tools/debug/sharing/?q=http%3A%2F%2Fcastus.dk%2Fprodukter%2Ffrugtpalaeg-med-kakao%2F

Technical info

phh commented 8 years ago

This might be a WP issue instead - due to sanitize_file_name accepting these letters. I might open a WP trac aswell.

Update: Seems like one already exists here: https://core.trac.wordpress.org/ticket/15955

Rarst commented 8 years ago

Debugger says the problem is with the image size, same as another issue you opened?

phh commented 8 years ago

Yes - since I opened the other issue I've made a quickfix for that site using the wpseo_opengraph_image_size filter and returning a smaller image size.

Rarst commented 8 years ago

I mean I don't quite follow what it is the issue with letters, if Debugger doesn't complain about that? :)

phh commented 8 years ago

The debugger does complain about the letters:

"Image Unavailable

Provided og:image, http://castus.dk/wp-content/uploads/2013/06/Kakao-Frugtpålæg-72dpi-476x785.png could not be downloaded because it exceeded the maximum allowed sized of 8Mb or your server was too slow to respond."

Rarst commented 8 years ago

It doesn't explicitly say that letters are the reason though? Might be likely, but I am not sure how much we can do in the plugin about that.

Rarst commented 8 years ago

Related #595

rolandorocha commented 8 years ago

it seems that is already working @phh . I have the same issue. what have you done?

phh commented 8 years ago

@rolandorocha By using this plugin: https://wordpress.org/plugins/wp-sanitize-file-name-plus/

But it will only fix the file names when the plugin has been activated - not before. Even after using regenerate thumbnails.

Rarst commented 7 years ago

Closing in favor of issue in core. This really feels like something more suited upstream and carefully handled for general case.