Yoast / wordpress-seo

Yoast SEO for WordPress
https://yoast.com/wordpress/plugins/seo/
Other
1.75k stars 885 forks source link

Meta description does not save when slug UI is removed #4512

Closed tac-design closed 6 years ago

tac-design commented 8 years ago

When the meta description field is edited I would expect it to be analysed in real-time and changes applied to the snippet preview.

Meta description is not saved in real-time. When the post is saved/published the meta description is not saved and returns to default.

Each character typed in the meta description field produces the following error:

TypeError: Attempted to assign to readonly property. setDataFromSnippetwp-seo-post-scraper-324.min.js:1:6166 saveSnippetDatawp-seo-post-scraper-324.min.js:1:6608 (anonymous function) updateDataFromDOMwp-seo-post-scraper-324.min.js:7:2171 (anonymous function)wp-seo-post-scraper-324.min.js:7:1851 dwp-seo-post-scraper-324.min.js:4:14695 owp-seo-post-scraper-324.min.js:4:14987 nwp-seo-post-scraper-324.min.js:4:14904

Disabled all plugins and the issue still occurs.

Rarst commented 8 years ago

Hmmm, cannot reproduce on trunk.

What is your browser/version? Could you please try a different one?

tac-design commented 8 years ago

Safari 9.0.3.

Just tested on Chrome and Firefox too and getting the same issue. Tried on a couple of sites on different hosting platforms and getting the issue everywhere.

stompweb commented 8 years ago

I had this problem too and I managed to narrow it down to something that I do when I clean up the edit post admin:

remove_meta_box( 'slugdiv','post','normal');

So when I remove the slugdiv then the edit meta description doesn't work.

terw-dan commented 8 years ago

@tac-design did you also use a remove_meta_box?

terw-dan commented 8 years ago

@stompweb Can you make a seperate issue for this? I don't know if this is related to this issue, and if you could make a detailed description we can look into it.

tac-design commented 8 years ago

It's the same issue - we use remove_meta_box too.

Niackery commented 8 years ago

Tested and confirmed. Using the snippet editor, I couldn't save the meta description or the url. After commenting out remove_meta_box( 'slugdiv' , 'post' , 'normal' ); everything works as expected. The only difference in my case is that I was trying to save a post draft rather than publish a post.

mleung07 commented 8 years ago

which file is the remove_meta_box( 'slugdiv' , 'post' , 'normal' ); located? where can I comment this out?

Rarst commented 8 years ago

@mleung07 that is not something present by default, it's usually a tweak in custom code somewhere.

mleung07 commented 8 years ago

@Rarst But where can I find it, as I am also facing the same problem, the change in meta description in the snippet can't be saved. thanks

Rarst commented 8 years ago

@mleung07 we can't know where would it be in your specific install and for what reason.

mmikhan commented 8 years ago

Please inform the customer of conversation # 118316 when this conversation has been closed.

Pcosta88 commented 8 years ago

Please inform the customer of conversation # 122950 when this conversation has been closed. Additional Info JavaScript error message appears only when SEO Snippet Tool is clicked. TypeError: Cannot set property 'value' of null /wp/wp-content/plugins/wordpress-seo-premium/js/dist/wp-seo-post-scraper-324.min.js?ver=3.2.5:1 Tech Specs: WordPress 4.5.2 Yoast SEO Premium: 3.2.5 User's Theme: Accelerate 1.2.5

Niackery commented 7 years ago

Just tested this a bit further... It looks like all changes made in the Snippet Editor now appear in real time, and changes to the meta description are indeed saved. Changes to the slug still don't save, and I think this is probably somehow related to the fact that changes made via the Edit Permalink button beneath the title also don't save.

benvaassen commented 6 years ago

We are no longer able to reproduce this issue. Therefore, I'm closing this. If the issue still persists, please follow these guidelines to open up a new bug report.