search

Yoast / wordpress-seo

Yoast SEO for WordPress
https://yoast.com/wordpress/plugins/seo/
Other
1.76k stars 890 forks source link

Error adding Taxonomy Term with Custom field #5545

Closed candymac closed 7 years ago

candymac commented 8 years ago

What did you expect to happen?

I expected to add a new term to a custom taxonomy which included a field for additional meta data (The field was an image field for a logo and was added using Advanced Custom Fields)

What happened instead?

The term was not added and the console displayed this error:

wp-seo-premium-quickedit-notification-352.min.js?ver=3.5.2:1 Uncaught TypeError: Cannot read property 'replace' of undefined

How can we reproduce this behavior?

Install Yoast SEO, Create a custom taxonomy, add a field for additional term meta data [ideally using ACF], attempt to add and save a term. Taxonomies without custom fields are fine.

Technical info

Rarst commented 8 years ago

Is this specific to Premium plugin?

Please contact Premium support via support@yoast.com for issues specific to it. This repository primarily handles Free plugin.

candymac commented 8 years ago

Ah, thanks for the info ... I couldn't reproduce with the free plugin, so it does indeed seem to be a premium specific issue. I'll contact support.

pixeline commented 7 years ago

Same here, with the Premium plugin. I'll contact support and post it here because, honestly, it's only fair that people considering buying the plugin know in advance that it may cause issue if they also use ACF.

to reproduce

  1. Create a custom taxonomy
  2. Assign it a few custom fields via ACF Pro (in my case 2 “image” custom fields)
  3. Try adding a term for that taxonomy
  4. Activate your plugin
  5. Try adding another term
  6. it does not work, console shows a javascript error pointing to wp-seo-premium-quickedit-notification-352.min.js.

HTH

gopeter commented 7 years ago

+1

daviddarke commented 7 years ago

+1

halley-edmond commented 7 years ago

+1 Any solutions?

daviddarke commented 7 years ago

@halley-edmond According to the 'premium' support, the only way to solve this currently is to de-activate the SEO plugin when you want to edit your taxonomies.... not great...

daviddarke commented 7 years ago

They did say that there is an alert list for when this issue is resolved. Drop them an email to get added.

radius commented 7 years ago

+1

hypercodex commented 7 years ago

+1

Pcosta88 commented 7 years ago

If these issues are specific to the premium plugin, we ask that you please contact Premium support via support@yoast.com. When you respond please include the following:

  1. License. If you are not sure of your license you can enter the email address used to purchase the plugin in the retrieval section to get it: https://yoast.com/licenses/
  2. Brief description of the issue you are experiencing.
  3. If you know you are experiencing the JavaScript issue with Advanced Custom Fields (ACF) and Yoast, let us know that too.
  4. Version numbers of Yoast SEO Premium, ACF, and WordPress Core.

This repository primarily handles the free plugin.

daviddarke commented 7 years ago

@Pcosta88 I get how it's not directly related to the free version of the plugin. Yet I feel there needs to a public record of this bug and it's history somewhere. I've had to remove Yoast Pro from 10 client sites due to this. Especially as the current solution is 'turn off the plugin'. This isn't really viable due the users that can edit taxonomies on our sites, won't have admin / plugin access.