Yoast / wordpress-seo

Yoast SEO for WordPress
https://yoast.com/wordpress/plugins/seo/
Other
1.77k stars 894 forks source link

Focus keyword text field is missing after updating to WP 4.7 #6232

Closed gergs closed 7 years ago

gergs commented 7 years ago

What did you expect to happen?

The focus keyword field should appear below the snippet preview. The SEO score indicator should appear in the Publish box.

What happened instead?

The focus keyword text field is missing. The SEO score indicator is also missing from the Publish box.

How can we reproduce this behavior?

Update to WP 4.7 with Yoast SEO 3.9. I tried reverting to the Twentysixteen theme and deactivating other plugins. Page SEO Meta Screenshot: https://www.dropbox.com/s/lo62mx1yniamzgj/Screenshot%202016-12-08%2010.31.06.png?dl=0 Page Publish Meta Screenshot: https://www.dropbox.com/s/qpnwcppelztzol6/Screenshot%202016-12-08%2010.38.15.png?dl=0

Technical info

Rarst commented 7 years ago

Are there any PHP errors (with WP_DEBUG enabled) or JavaScript errors in browser console?

gergs commented 7 years ago

No, there are no PHP or console errors. I have debugging enabled.

Rarst commented 7 years ago

I cannot reproduce in my dev install, and since you tried core theme/disabling other stuff this is quite puzzling.

Can you try deleting plugin and installing a clean copy? Might be a weird case of update failure.

gergs commented 7 years ago

I tried uninstalling and re-installing without success.

Rarst commented 7 years ago

Hm hm... Can you use browser tools to check it markup/text for the missing bits is there? Can be some CSS issue hiding it.

gergs commented 7 years ago

No problem.

The markup is missing from the Publish meta box. Screenshot: https://www.dropbox.com/s/rpcpp3o7uasjbzp/Screenshot%202016-12-09%2012.03.26.png?dl=0

The focus keyword and page analysis are NOT missing from the #wpseo_meta meta box; however, they are being hidden via CSS for some reason. I again verified these are hidden while plugins are disabled and the theme is twentysixteen. Screenshot: https://www.dropbox.com/s/pyh851r1ivq0jbk/Screenshot%202016-12-09%2012.12.02.png?dl=0

gergs commented 7 years ago

The #wpseo-pageanalysis div is being hidden with inline CSS as well. I am able to override this with my own CSS but this is certainly weird.

Screenshot: https://www.dropbox.com/s/w7pa4u89cgh8xmz/Screenshot%202016-12-09%2012.23.45.png?dl=0

Rarst commented 7 years ago

Could you please check that any and all browser or proxy caches involved are flushed?

I think it's "normal" for markup being loaded hidden and then "booted up" with JS, but something seems to go wrong there...

gergs commented 7 years ago

I have cleared my browser cache again and disabled adblocker. I've also tested this from a different machine and browser. The wpseo-pageanalysis div is empty even though I have filled out the focus keyword and updated the page.

<div id="wpseo-pageanalysis" style="display: none;"></div>

stodorovic commented 7 years ago

@gergs Did you check SEO settings? SEO -> Titles & Metas -> General yoast-seo-readability-keywords

PS. I can reproduce something similar when settings are disabled (I see style="display: none;").

gergs commented 7 years ago

As a test, I disabled readability and keyword analysis and then re-enabled but this didn't fix the situation. I wish it was that simple!

stodorovic commented 7 years ago

Please install QM (Query monitor - https://wordpress.org/plugins/query-monitor/) which is very helpful plugin for debugging.

Open page/post in WP editor. If you can't open QM menu, there are JS errors (maybe they are hidden). If you can open QM menu, try to find scripts:

yoast-seo-qm-scripts

Does QM show any errors? Are there all scripts ?

gergs commented 7 years ago

What do you want to see? I'm not sure how to debug this based on what the query monitor is showing.

screenshot 2016-12-12 09 26 27 screenshot 2016-12-12 09 28 08 screenshot 2016-12-12 09 29 04

stodorovic commented 7 years ago

I wanted to see scripts (Javascript works without errors because you see QM menu). Some confirmation that there are all yoast scripts (submenu scripts). Just compare my output and your output.

QM doesn't show any PHP errors, but I noticed that PHP version is pretty outdated (5.4.13 - 14 Mar 2013). Last version (PHP 5,4) is 5.4.45 - 03 Sep 2015. My minimal version is PHP 5.5.38 and I can't reproduce your issue on same PHP version. I can't say that's reason.

If you have installed latest version, WP recomended PHP 7 (or at least 5.6) https://wordpress.org/about/requirements/ I don't know is it possible to update PHP on your hosting. Also, I can't know reason why you use PHP 5.4.13, maybe you need older version.

I've installed WP 4.6, Twenty Sixteen 1.3, Yoast SEO 3.9 on PHP 5.5.38. It works. Then I've updated WP to 4.7. It still works.

I didn't notice same issue (WP 4.7, Yoast SEO 3.9). I've installed PHP 5.5.38, 5.6.27, 7.0.12. All variants work as should.

meninesiela commented 7 years ago

I also see QM menu. My PHP 5.6.27 . error_reporting - 4983 . I found yost scripts on QM . Before updates everything was fine. Tried disable plugins, or that enable disable thing on yost - same problem. (Wp 4.6.1 Yost 3.9 Betheme 14,9)

gergs commented 7 years ago

I don't see any of the line items from your screenshot. I don't see any line item that mentions 'yoast'. I looked in Queries and Scripts. I'm working on updating PHP to 7 and will reply back once that's done and I have re-tested.

meninesiela commented 7 years ago

at first i didn't find too try chrome-explorer so on seach bar with word yoast will find all lines wit hthat word. We have same issue but one difference. You upgraded to 4.7 wordpress then it appeared (as i understood) i updated yoast to 3.9 and maybe WMPL multilanguage and then appeared it.

Gergs i have same problem as you, but mines topic closed as the same problem as you mentioned first about it. I hope it can be fixed somehow. Really liked this plugin.

stodorovic commented 7 years ago

@meninesiela Did you try re-isntall plugin? All your settings are safe. Try to deactivate plugin, remove plugin directory via FTP, extract fresh version of plugin (https://downloads.wordpress.org/plugin/wordpress-seo.3.9.zip) and upload there. I don't have more idea.

I'll try (tomorrow) to install WP 4.6, some older Yoast SEO, older WPML and try to update everything. Which are your previous versions?

gergs commented 7 years ago

Yes, we already uninstalled and re-installed the plugin. I tried to replicate the issue via other sites we maintain doing just as you're proposing and we couldn't replicate the issue either.

meninesiela commented 7 years ago

stodorovic i can try this, thanks, but i have a lot of products ant site links, i spent a lot of time writing meta destriptions titles and so on yoastseo very afraid that it will gone after.

stodorovic commented 7 years ago

All meta descriptions and titles are saved in postmeta fields. Deactivation/activation doesn't remove anything. If you deactivate plugin, remove plugin directory, extract new version and activate plugin again, then it's exact procedure which WP does at each update.

Anyway, you can make backup before it, if you afraid. (You can use plugin updraftplus backup - one of the best and common backup plugins)

PS. you don't have to do uninstall, you should to deactivate plugin from WP dashboard. wp-content/plugins./wordpress-seo contains only the code.

gergs commented 7 years ago

I was finally able to upgrade the php server to 7 and re-test. This didn't resolve the issue. I am pasting a portion of the query results which show yoast data.

screenshot 2016-12-14 08 56 23

stodorovic commented 7 years ago

Hm.. I see scripts from other plugins there. (eg. Admin Menu Editor, Advanced custom fields, Gravitiy form). If you send exact list of plugins (and versions), I'll try to reproduce your issue on PHP 7.0.

PS. I tried update from 3.8 to 3.9, then 3.9 to 4.0 and I can't reproduce it. I tried to update few websites (3.9 to 4.0) and I didn't notice any issue for now. Did you try Yoast SEO 4.0?

gergs commented 7 years ago

Yes, we've already updated to 4.0.

We've already tested everything with all plugins disabled and with the Twentysixteen theme active but have had to reactivate plugins and the custom theme we developed so that we can continue to develop the site.

Add Descendants As Submenu Items (1.2.0) Automatically all of a nav menu item's descendants as submenu items. Designed for pages but will work with any hierarchical post type or taxonomy.

Admin Menu Editor Pro (2.4.2) Lets you directly edit the WordPress admin menu. You can re-order, hide or rename existing menus, add custom menus and more.

Admin Theme (1.0) Brands and styles the admin and login screens for this website.

Advanced Custom Fields PRO (5.5.2)

BackWPup (3.3.4)

Capability Manager Enhanced (1.5.7)

EWWW Image Optimizer (3.1.3)

Gravity Forms (2.1.1)

Gravity Forms MailChimp Add-On (3.7.1)

IM8 Exclude Pages (2.7)

Intuitive Custom Post Order (3.0.7)

List Plugins (1.4.4) Create a list of the active plugins in a page (when the shortcode [list_plugins] is found).

miniOrange SSO using SAML 2.0 (11.1.9)

miniOrange SAML 2.0 SSO enables user to perform Single Sign On with any SAML 2.0 enabled Identity Provider.

Multiple Roles (1.1.1)

Peter's Login Redirect (2.9.1)

Post Thumbnail Editor (2.4.8)

Query Monitor (2.13.2)

Relevanssi Premium (1.14.6.1) This premium plugin replaces WordPress search with a relevance-sorting search.

User Management (Manage User Roles, Capabilities, Membership) (11.16.0) User Management plugin to manage your users, roles and capabilities. Create custom registration forms fields and approve users after registration. Simple and customizable with active support.

User Switching (1.0.9)

What Template File Am I Viewing? (1.2)

WordPress Toolbar Editor (1.2.1) Lets you edit the WordPress Toolbar (a.k.a. Admin Bar) - the horizontal menu at the top of your page that shows up when you're logged in. You can hide, move, rename and edit existing items, as well as create new menu items. Requires Admin Menu Editor Pro.

Yoast SEO (4.0)

meninesiela commented 7 years ago

I also uninstalled plugin and reinstalled yoast 4 - same problem.

meninesiela commented 7 years ago

problem persist even after 4.0.2 update, please fix it.

stodorovic commented 7 years ago

I tried to install many plugins from gergs list and I can't reproduce this issue. Can you check something simple? It's possible that's disabled in user profile. You will see options if you open user profile: yoast-seo-user-profile-seo

I'll try to make simple PHP script which checks all options, maybe it'll be faster for checking.

@meninesiela Can you look list of plugin and write which plugins from gergs list you have installed? Then I'll focus on these plugins.

meninesiela commented 7 years ago

Only one same is Yoast, and one a bit similar - "Advanced Custom Fields Multilingual 0,3 version. But A good news that this thing with profile fixed it.. I went to profile and really all three - "disable seo analysis , disable readability , and exlude" - was marked. I unmarked both Disable and for that time - everything works fine. So for me - there was a problem. Thank you very much!

gergs commented 7 years ago

@stodorovic I can't believe that worked! I had no idea that those checkboxes were a setting for the entire site. I thought they pertained to the user I was editing (including my profile). As far as my original issue, this is resolved. So sorry for the false bug report and thanks for the superior support!

stodorovic commented 7 years ago

Thanks. Glad to hear to this worked. Finally, we found root of this issue.

Just information related to this. Spanish translation is still wrong. I don't know Spanish, but original issue is https://wordpress.org/support/topic/yoast-doesnt-show-keyword/

http://translate.yoast.com/gp/projects/wordpress-seo/es/default/?filters[term]=Disable+SEO+analysis Google translate shows for "Mostrar análisis SEO": Show SEO Analytics

Garcialaso (wordpress.org) has written: It was a problem with the user section. There was a bad translation: “Mostrar análisis SEO” instead “Desactivar análisis SEO”

@fernandotellado Can you look this?

fernandotellado commented 7 years ago

Of course, it's wrong

CarolineGeven commented 7 years ago

Closing as this issue is solved.

HSinghHira commented 7 years ago

How to fix this? I mean if element's display style is at none then.... What thing can causing problem?

2017-08-11_08h27_24