search

Yoast / yoast-acf-analysis

WordPress plugin that adds the content of all ACF fields to the Yoast SEO score analysis.
https://wordpress.org/plugins/acf-content-analysis-for-yoast-seo/
GNU General Public License v3.0
61 stars 20 forks source link

Determine select2 version from ACF instead of guessing from ACF version #105

Closed kraftner closed 7 years ago

kraftner commented 7 years ago

fixes #79

This could probably still be improved as the case of ACF5 with select2 v3 is now not actually covered by the tests. But for that I am waiting for #103 because it will add the infrastructure to add a CPT for which we could then switch select2 to v3.

andizer commented 7 years ago

CR done. I've one single suggestion.

moorscode commented 7 years ago

Acceptance done