search

Yoast / yoast-acf-analysis

WordPress plugin that adds the content of all ACF fields to the Yoast SEO score analysis.
https://wordpress.org/plugins/acf-content-analysis-for-yoast-seo/
GNU General Public License v3.0
62 stars 20 forks source link

High Number of ‘query-attachments’ #120

Open kraftner opened 6 years ago

kraftner commented 6 years ago

A user reported this in the forum:

We are seeing an issue when we have this plugin enabled where there are multiple calls being made to /wp-admin/admin-ajax.php when editing a page. The POST variables details are:

query[post__in][]: action:query-attachments

On initially entering the editing of the page we see 3 or 4 identical calls to this method, but for some users this can spike to up to 40 (these seem to be users on lower bandwidth). https://wordpress.org/support/topic/high-number-of-query-attachments/

This seems to come from https://github.com/Yoast/yoast-acf-analysis/blob/6f5373b93cb392a210282da21f5a304472f9b5e6/js/src/cache/cache.attachments.js#L11-L15 but I'm not sure what exactly is going on. Needs further investigation.

Technical info

steveperrycreative commented 6 years ago

I can also confirm this in WP 4.9.1 and 4.9.2 with ACF Pro 5.6.7 and Yoast SEO 6.1.1. PHP 7.2.

screen shot 2018-01-18 at 15 40 54
steveperrycreative commented 6 years ago

Do we have a timeline for this? It's quite a critical issue and can take servers offline due to load.

kraftner commented 6 years ago

Unfortunately everyone involved seems to be busy these days, so I can't really give you an ETA.

If you feel like helping to speed up the process feel free to file a PR :wink:

steveperrycreative commented 6 years ago

@kraftner thanks for the response. I appreciate the work involved and the process behind it. I'll see what I can do.

gavin310 commented 6 years ago

Has this plugin been abandoned or what? I thought Yoast's team was going to maintain it?

nrdq commented 6 years ago

@kraftner Please fix this terrible bug!

kristjan72 commented 5 years ago

Is this still an issue?

steveperrycreative commented 5 years ago

I've not noticed any issues lately but not 100% sure.

fisaman commented 3 years ago

Hi, i still have the problem.

Too much get-attachement admin-ajax.php requests with yoasts plugin enabled

When I edit a page of the site the loading time is very high and the consumption of RAM and CPU is also very high.

In the network inspector I see that there are too many requests to the admin-ajax.php script with the get-attachment method.

This happens when I have the Yoast SEO plugin activated, if I deactivate Yoast these requests are not made.

I have all the plugins updated.

Screenshot: https://pasteboard.co/JCttWFz.jpg https://pasteboard.co/JCtu9kf.jpg

How can I solve?

---- Configuration ---- Theme The7 v.9.3.1 The7 WPBackery Page Builder 6.4.2 Ultimate Addons for WPBakery Page Builder 3.19.7 Yoast SEO 15.3

I tried PHP 7.2, 7.3 and 7.4 PHP Max Input Vars: 10000 PHP Memory Limit: 512 MB PHP Time Limit: 360

Bernier154 commented 6 months ago

The bug still exists, had to disable the plugin on a client's website today.