search

Yoast / yoast-acf-analysis

WordPress plugin that adds the content of all ACF fields to the Yoast SEO score analysis.
https://wordpress.org/plugins/acf-content-analysis-for-yoast-seo/
GNU General Public License v3.0
61 stars 20 forks source link

JavaScript Errors appear when ACF rules for Taxonomy set equal to Product Categories. Results in inability to add categories #13

Closed Pcosta88 closed 6 years ago

Pcosta88 commented 8 years ago

What did you expect to happen?

No errors would be generated

What happened instead?

JavaScript errors were generated

How can we reproduce this behavior?

1.Install Advanced Custom Fields (Pro or free)

2.Install Yoast SEO Premium

3.Install Yoast ACF SEO Analysis

4.Make a field set to taxonomy for product categories. Use WYSIWYG editor (also happens with text editor)

screen shot 2016-09-19 at 10 28 16 am

5.Create a product_cat

screen shot 2016-09-19 at 10 29 37 am

5.See briefly that JavaScript errors are thrown out

TypeError: Cannot read property 'replace' of undefined
 /wp-content/plugins/wordpress-seo-premium/premium/assets/js/dist/wp-seo-premium-quickedit-notification-352.min.js?ver=3.5.2:1

6.See that product cat is still created

screen shot 2016-09-19 at 10 30 00 am

7.Switch to Advanced Custom Fields Pro while using Yoast SEO Premium

8.Add a field, create product cat, see that JavaScript errors are thrown out as above. See also that the product cat fails to be added.

screen shot 2016-09-19 at 10 33 09 am

9.Keep Advanced Custom Fields Pro active while using Yoast SEO (free). See that no JavaScript errors are thrown out AND product cat is added as expected.

10.Advanced Custom Fields (free one) and Yoast SEO (free) do not result in the JavaScript Errors

Can you provide a link to a page which shows this issue?

Technical info

Pcosta88 commented 8 years ago

Please inform the customer of conversation # 147154 when this conversation has been closed.

mikakaltoft commented 8 years ago

@Pcosta88 What is status on this issue?

Pcosta88 commented 8 years ago

@mikakaltoft The issue was also reported in another repository here:https://github.com/Yoast/wordpress-seo-premium/issues/770. On the right-side you can view the progress of the issue under the title "Milestone".

kraftner commented 7 years ago

I feel like this is an issue with Yoast SEO itself and not this plugin. @Pcosta88 can you check with the premium repo to see if this might already be resolved there so we can close this issue?

Pcosta88 commented 7 years ago

@kraftner Confirmed: https://github.com/Yoast/wordpress-seo-premium/issues/770

kraftner commented 6 years ago

@Pcosta88 Somehow this slipped through - by confirmed you mean this issue is now fixed and can be closed?

Pcosta88 commented 6 years ago

@kraftner Correct, The premium repo is closed. This issue was resolved in Yoast SEO (free or premium) v4.6

kraftner commented 6 years ago

Thx! Hence closing this.