This PR can be summarized in the following changelog entry:
N/A
Relevant technical choices:
No functional changes.
Code style compliance.
As discussed with @moorscode.
Renames test classes to use underscores to separate words
Adjusts the file names for class files to be in line with the rules as laid out in the Yoast.Files.FileName sniff.
Ref: Yoast/yoastcs#48
Remove class- prefixes from the plugin file names.
Remove yoast-acf-analysis prefixes from the plugin file names.
Make sure that the file names accurately reflect the class names (excluding the prefixes).
IMPORTANT I noticed when committing the file renames, that the file mode for a number of these files has also been changed from 755 to 644. This change was unintentional, however, does look like a more sensible file mode to me.
Please let me know if this is undesired/if there was any special reason why these files had mode 755.
Where necessary, adjusted any include/requires to point to the new file names.
[ ] Note: The classmap autoload files for Composer will need to be regenerated!
Test instructions
This PR can be tested by following these steps:
See if the plugin still loads as expected, functions as expected, unit tests still run as expected etc.
jcomack
commented
6 years ago
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
As discussed with @moorscode.
Yoast.Files.FileNamesniff. Ref: Yoast/yoastcs#48class-prefixes from the plugin file names.yoast-acf-analysisprefixes from the plugin file names.modefor a number of these files has also been changed from755to644. This change was unintentional, however, does look like a more sensible file mode to me. Please let me know if this is undesired/if there was any special reason why these files had mode755.Where necessary, adjusted any
include/requires to point to the new file names.Test instructions
This PR can be tested by following these steps: