search

Yoast / yoast-acf-analysis

WordPress plugin that adds the content of all ACF fields to the Yoast SEO score analysis.
https://wordpress.org/plugins/acf-content-analysis-for-yoast-seo/
GNU General Public License v3.0
61 stars 20 forks source link

Build/Travis: test builds against PHP 7.3 #165

Closed jrfnl closed 6 years ago

jrfnl commented 6 years ago

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

Once PHP 7.3-beta came out, the nightly build on Travis became PHP 7.4-dev and builds haven't been tested against PHP 7.3 for months now.

As of this week, Travis has (finally) made a PHP 7.3 alias available now RC3 is out, so I've updated the highest PHP version to test against to PHP 7.3/WP 5.0 so there won't be any unwelcome surprises when PHP 7.3/WP 5.0 comes out.

Note: I've adjusted the WP versions for the other unit test builds to match, i.e. upped them one minor.

Test instructions

This PR can be tested by following these steps:

IreneStr commented 6 years ago

This PR is blocked for the time being for the same reason as https://github.com/Yoast/wpseo-woocommerce/pull/285: We'll wait until 5.0 has been released.

jrfnl commented 6 years ago

@IreneStr Help me out: why ? The builds for this plugin are not affected by any WP incompatibilities with PHP 7.3 as can be seen in the Travis results (which pass and yes, I have tested with the unit tests enabled as well, i.e. this PR combined with #166), so why wait with testing against PHP 7.3/WP 5.0 until the releases have come out ?

IreneStr commented 6 years ago

Unblocking. The crucial difference with Yoast/wpseo-woocommerce#285 is that on that repo some rules needed to be ignored to let travis pass. That's not the case with this one. Please merge #166 first.