ACF blocks support - Githubissues

Yoast / yoast-acf-analysis

WordPress plugin that adds the content of all ACF fields to the Yoast SEO score analysis.

https://wordpress.org/plugins/acf-content-analysis-for-yoast-seo/

GNU General Public License v3.0

61 stars 20 forks source link

ACF blocks support #243

Closed TimVevida closed 4 years ago

TimVevida commented 4 years ago

Summary

Proof of concept that ACF block previews can be passed to Yoast SEO.

This PR can be summarized in the following changelog entry:

Add support for ACF blocks. Props to TimVevida.

Relevant technical choices:

Passes the complete block preview to Yoast SEO. This means that in selected mode (when the preview is visible and the edit fields are visible in the sidebar), the content is passed twice to Yoast SEO. This needs a solution.

Test instructions

This PR can be tested by following these steps:

Create a custom Gutenberg block using ACF (See ACF blocks)
Add the custom block to a post
Check that content is being passed to Yoast SEO by watching the debug info or the changing Yoast recommendations.

Fixes #241

TimVevida commented 4 years ago

the content is passed twice to Yoast SEO.

This is fixed with commit 1e1a2df

The Travis CI is now failing because there are too many warnings, not something I should fix in this pull request IMHO.

Due to the Corona virus, I am bound to a Windows PC and could not perform the tests locally.

TimVevida commented 4 years ago

@jrfnl Seems like you are the most frequent committer here, want to take a look at this PR?

jrfnl commented 4 years ago

Hi @TimVevida Thanks for this PR. I'm not the best person to review this, but I've checked and someone else will take a look at this PR in the near future.

Regarding the warnings you see in the CI: it's true that you don't need to fix (pre-)existing issues and shouldn't in this PR, but I would like to ask you to double-check that the code affected by this PR doesn't introduce any new issues. If it does, those would need to be fixed before the PR can get merged.

TimVevida commented 4 years ago

I have fixed some lint issues related to this PR and the build now passes.

jrfnl commented 4 years ago

@TimVevida Excellent! Thank you.

DB-Alex commented 4 years ago

@jrfnl is there any timeframe when this will be merged?

And will it also work in Yoast Premium plugin?

IreneStr commented 4 years ago

@TimVevida Thank you for your PR. My apologies for not having someone looking at it sooner. I'll make sure one of our devs will look at your PR this week. There is no need to make additional changes to make it work with Premium as well (as far as I can see).

DB-Alex commented 4 years ago

@IreneStr Thats great news!

JesserH commented 4 years ago

CR and Acceptance ☑️ :)