Yoast / yoast-acf-analysis

WordPress plugin that adds the content of all ACF fields to the Yoast SEO score analysis.
https://wordpress.org/plugins/acf-content-analysis-for-yoast-seo/
GNU General Public License v3.0
61 stars 20 forks source link

PHPCS: enable caching between runs #263

Closed jrfnl closed 4 years ago

jrfnl commented 4 years ago

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

Since PHPCS 3.0.0, PHPCS has a caching feature available. In this PR, this caching feature is now turned on for this repo.

This means in effect that the very first run of PHPCS with this feature will be marginally slower (on any individual machine). Most runs after that though, will be significantly faster as PHPCS will only scan the files which have changed since the previous run.

The cache will automatically be invalidated and rebuild whenever relevant, like when the version of one of the PHPCS dependencies has changed or when PHPCS itself has been changed.

To (temporarily) turn caching off, run PHPCS like so:

composer check-cs -- --no-cache

The cache file is set to be saved to a .cache directory to allow Travis to benefit from this feature as well. As this directory has to exist for the cache file to be written to it, it is created and committed to the repo with a .gitkeep file

Commit details:

/.cache/ directory:

PHPCS config file:

.gitignore:

.gitattributes:

Travis:

Test instructions

This PR can be tested by following these steps:

Testing this PR

Also verify that Travis correctly caches the .cache directory. While that won't make a difference for this build, it should for future builds.