QAK-2538 hotfix error on term pages - Githubissues

Yoast / yoast-acf-analysis

WordPress plugin that adds the content of all ACF fields to the Yoast SEO score analysis.

https://wordpress.org/plugins/acf-content-analysis-for-yoast-seo/

GNU General Public License v3.0

62 stars 20 forks source link

QAK-2538 hotfix error on term pages #285

Closed igorschoester closed 3 years ago

igorschoester commented 3 years ago

Summary

This PR can be summarized in the following changelog entry:

Fixes a bug where ACF Analysis would fail on term pages when using WordPress 5.6.

Relevant technical choices:

This is a load order problem. In the term-scraper of Yoast SEO we still use jQuery( document ).ready. 100ms should be enough to run after the term-scraper initialization. Alternatively we could remove jQuery ready there. Resulting in both "only" using WP's domReady, which would work too.

Test instructions

This PR can be tested by following these steps:

Install and activate the following plugins on WordPress 5.6: Yoast SEO 15.4, ACF Content Analysis for Yoast SEO 3.0.1 (or 3.0.1-RC1) and Advanced Custom Fields 5.9.3
Configure ACF to show a custom text field on taxonomy forms (see screenshot in issue)
Open the browser console and visit a taxonomy edit page
Notice the error is no longer in the console.

Fixes https://yoast.atlassian.net/browse/QAK-2538