This PR can be summarized in the following changelog entry:
Updates test configuration
Relevant technical choices:
PHPUnit recently released version 9.5.10 and 8.5.21.
This contains a particular (IMO breaking) change:
PHPUnit no longer converts PHP deprecations to exceptions by default (configure convertDeprecationsToExceptions="true" to enable this)
Let's unpack this:
Previously (PHPUnit < 9.5.10/8.5.21), if PHPUnit would encounter a PHP native deprecation notice, it would:
Show a test which causes a deprecation notice to be thrown as "errored",
Show the first deprecation notice it encountered and
PHPUnit would exit with a non-0 exit code (2), which will fail a CI build.
As of PHPUnit 9.5.10/8.5.21, if PHPUnit encounters a PHP native deprecation notice, it will no longer do so. Instead PHPUnit will:
Show a test which causes a PHP deprecation notice to be thrown as "risky",
Show the all deprecation notices it encountered and
PHPUnit will exit with a 0 exit code, which will show a CI build as passing.
This commit reverts PHPUnit to the previous behaviour by adding convertDeprecationsToExceptions="true" to the PHPUnit configuration.
It also adds the other related directives for consistency.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
PHPUnit recently released version 9.5.10 and 8.5.21.
This contains a particular (IMO breaking) change:
Let's unpack this:
Previously (PHPUnit < 9.5.10/8.5.21), if PHPUnit would encounter a PHP native deprecation notice, it would:
As of PHPUnit 9.5.10/8.5.21, if PHPUnit encounters a PHP native deprecation notice, it will no longer do so. Instead PHPUnit will:
This commit reverts PHPUnit to the previous behaviour by adding
convertDeprecationsToExceptions="true"
to the PHPUnit configuration. It also adds the other related directives for consistency.Refs:
Test instructions
This PR can be tested by following these steps: